Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insecure hashing in bn256/sign method #122

Open
nikkolasg opened this issue Feb 4, 2019 · 3 comments
Open

Insecure hashing in bn256/sign method #122

nikkolasg opened this issue Feb 4, 2019 · 3 comments

Comments

@nikkolasg
Copy link
Collaborator

The method to hash a message to a point is insecure m -> scalar s -> s * G , as no easy method is provided by the go or cf packages and time pressure. We should try to implement a correct method, maybe by following the ideas in this paper https://www.di.ens.fr/~fouque/pub/latincrypt12.pdf . Although that will probably require forking off Go's or CF's package in order to access to the lower level methods.

@nkeywal
Copy link
Contributor

nkeywal commented Feb 15, 2019

discussion with @bkolad @nikkolasg
This is at the application level: the handel library does not take care of this point.
For Eth2, the Ethereum Foundation is still working on the hash function to use.

@nikkolasg
Copy link
Collaborator Author

good implementation : https://github.com/Project-Arda/bgls

@bkolad
Copy link
Contributor

bkolad commented Feb 26, 2019

we had bug in our hashing function, fixed in:
#124
The implementation still suffers from problems described by @nikkolasg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants