Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contracts): Document potential accounting issue with Module #824

Merged

Conversation

alainncls
Copy link
Collaborator

What does this PR do?

  • Adds NatSpec comments to warn of the potential issues when multiple Modules check the value sent
  • The documentation was updated (cf. this commit)

Related ticket

Fixes #823

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.55%. Comparing base (7f57adb) to head (e24b671).

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #824       +/-   ##
===========================================
+ Coverage   48.96%   74.55%   +25.58%     
===========================================
  Files          18       49       +31     
  Lines         388      892      +504     
  Branches       61      187      +126     
===========================================
+ Hits          190      665      +475     
- Misses        195      224       +29     
  Partials        3        3               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alainncls alainncls self-assigned this Nov 26, 2024
@alainncls alainncls force-pushed the chore/document-potential-accounting-issue-with-module branch from c81e981 to e24b671 Compare November 26, 2024 13:30
@alainncls alainncls merged commit 9ae6556 into dev Nov 26, 2024
9 checks passed
@alainncls alainncls deleted the chore/document-potential-accounting-issue-with-module branch November 26, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Document potential accounting issue with Modules
3 participants