Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contracts): Add a safety check against data corruption #839

Merged

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Nov 29, 2024

What does this PR do?

Checks attestation id is valid or not before generating it and using it

Related ticket

Fixes #808

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.24%. Comparing base (bc9809b) to head (58e8223).

Files with missing lines Patch % Lines
contracts/src/AttestationRegistry.sol 50.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #839       +/-   ##
===========================================
+ Coverage   48.59%   74.24%   +25.65%     
===========================================
  Files          18       51       +33     
  Lines         391      893      +502     
  Branches       63      186      +123     
===========================================
+ Hits          190      663      +473     
- Misses        198      224       +26     
- Partials        3        6        +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satyajeetkolhapure satyajeetkolhapure merged commit 251a440 into dev Nov 29, 2024
9 checks passed
@satyajeetkolhapure satyajeetkolhapure deleted the chore/add-a-safety-check-against-data-corruption branch November 29, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Add a safety check against data corruption
3 participants