Removing comments from mainnet trace-limits (#90)

* Removing comments from mainnet trace-limits * Using other sequencer plugin version
Consensys · Sep 18, 2024 · 3e3fdcc · 3e3fdcc
1 parent 4cbbe09
commit 3e3fdcc
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 19 deletions.
diff --git a/.github/workflows/develop.yaml b/.github/workflows/develop.yaml
@@ -107,7 +107,7 @@ jobs:
 
       - name: Start container
         run: |
-          COMMAND="docker run -d --name ${{ env.CONTAINER_NAME }} -e BESU_PROFILE=${{ matrix.file }} ${{ env.DOCKER_IMAGE }} "
+          COMMAND="docker run -d --name ${{ env.CONTAINER_NAME }} -e BESU_PROFILE=${{ matrix.file }} ${{ env.DOCKER_IMAGE }}"
           echo $COMMAND
           eval $COMMAND
 

diff --git a/linea-besu/build.json b/linea-besu/build.json
@@ -11,8 +11,8 @@
     {
       "type": "download",
       "name": "linea-sequencer",
-      "url": "https://github.com/Consensys/linea-sequencer/releases/download/v{version}/linea-sequencer-v{version}.jar",
-      "version": "0.6.0-rc1.1",
+      "url": "https://github.com/Consensys/linea-sequencer/releases/download/v{version}/besu-sequencer-plugins-v{version}.jar",
+      "version": "0.1.4-test33",
       "outputDir": "plugins"
     },
     {

diff --git a/linea-besu/config/trace-limits.mainnet.toml b/linea-besu/config/trace-limits.mainnet.toml
@@ -8,22 +8,22 @@ BIN_RT              = 262144
 EC_DATA             = 4084
 EXT                 = 1048500
 HUB                 = 2097150
-INSTRUCTION_DECODER = 512 # Ugly hack, TODO: @franklin
+INSTRUCTION_DECODER = 512
 MMIO                = 1048576
 MMU                 = 524288
 MMU_ID              = 256
 MOD                 = 131064
 MUL                 = 65527
 MXP                 = 524284
-PHONEY_RLP          = 65536 # can probably get lower
+PHONEY_RLP          = 65536
 PUB_HASH            = 30768
 PUB_HASH_INFO       = 8192
 OLD_PUB_HASH        = 32768
 OLD_PUB_HASH_INFO   = 8192
 PUB_LOG             = 14384
 PUB_LOG_INFO        = 49152
 RLP                 = 504
-ROM                 = 13000000 # need to be validated if there are changes in how Besu counts the ROM.
+ROM                 = 13000000
 ROM_LEX             = 3145728
 SHF                 = 65520
 SHF_RT              = 4096
@@ -45,8 +45,7 @@ EUC                 = 1000000
 #
 # Block-specific limits
 #
-BLOCK_TX       = 200 # max number of tx in an L2 block
-BLOCK_L1SIZE   = 108592
+BLOCK_TX       = 200
 BLOCK_L2L1LOGS = 16
 BLOCK_KECCAK   = 8192
 
@@ -58,19 +57,19 @@ PRECOMPILE_ECRECOVER_EFFECTIVE_CALL = 1000000
 PRECOMPILE_SHA2      = 100
 PRECOMPILE_SHA2_BLOCKS = 1000000
 PRECOMPILE_SHA2_EFFECTIVE_CALL = 1000000
-PRECOMPILE_RIPEMD    = 100 # keep 100 because we don't have better limit for now
+PRECOMPILE_RIPEMD    = 100
 PRECOMPILE_RIPEMD_EFFECTIVE_CALL = 1000000
 PRECOMPILE_RIPEMD_BLOCKS = 1000000
-PRECOMPILE_IDENTITY  = 10000 # we should not need this limit
-PRECOMPILE_MODEXP    = 1000 # should be decreased to 4
+PRECOMPILE_IDENTITY  = 10000
+PRECOMPILE_MODEXP    = 1000
 PRECOMPILE_MODEXP_EFFECTIVE_CALL = 1000
-PRECOMPILE_ECADD     = 1000 # should be 16384
+PRECOMPILE_ECADD     = 1000
 PRECOMPILE_ECADD_EFFECTIVE_CALL     = 1000000
-PRECOMPILE_ECMUL     = 100 # should be 32
+PRECOMPILE_ECMUL     = 100
 PRECOMPILE_ECMUL_EFFECTIVE_CALL     = 1000000
-PRECOMPILE_ECPAIRING = 100 # should be 16 #another limit is missing, is it ECPAIRING WEIGHTED?
+PRECOMPILE_ECPAIRING = 100
 PRECOMPILE_ECPAIRING_EFFECTIVE_CALL = 1000000
 PRECOMPILE_ECPAIRING_MILLER_LOOP = 1000000
 PRECOMPILE_BLAKE2F   = 512
 PRECOMPILE_BLAKE2F_ROUNDS = 1000000
-PRECOMPILE_ECPAIRING_WEIGHTED = 1000000 #should it be 64? today it's 1_000_000 to nerver trigger it.
+PRECOMPILE_ECPAIRING_WEIGHTED = 1000000
diff --git a/linea-besu/profiles/advanced-mainnet.toml b/linea-besu/profiles/advanced-mainnet.toml
@@ -70,7 +70,7 @@ target-gas-limit="61000000"
 ### Plugin Configuration ###
 #plugin-linea-min-margin="0.3"
 #plugin-linea-gas-price-ratio=12
-plugins=["LineaEndpointServicePlugin","L1FinalizationTagUpdaterPlugin"]
+plugins=["LineaEstimateGasEndpointPlugin","L1FinalizationTagUpdaterPlugin"]
 plugin-linea-module-limit-file-path="config/trace-limits.mainnet.toml"
 plugin-linea-max-tx-calldata-size=60000
 plugin-linea-max-block-calldata-size=70000
@@ -95,4 +95,5 @@ plugin-linea-l1l2-bridge-topic="e856c2b8bd4eb0027ce32eeaf595c21b0b6b4644b326e5b7
 plugin-linea-estimate-gas-compatibility-mode-multiplier="1.2"
 
 # L1FinalizationTagUpdaterPlugin
-plugin-linea-l1-smart-contract-address="0xd19d4B5d358258f05D7B411E21A1460D11B0876F"
+plugin-linea-l1-smart-contract-address="0xd19d4B5d358258f05D7B411E21A1460D11B0876F"
+plugin-linea-l1-rpc-endpoint="http://localhost:8545"
diff --git a/linea-besu/profiles/advanced-sepolia.toml b/linea-besu/profiles/advanced-sepolia.toml
@@ -68,7 +68,7 @@ min-gas-price="100000000"
 target-gas-limit="61000000"
 
 ### Plugin Configuration ###
-plugins=["LineaEndpointServicePlugin","L1FinalizationTagUpdaterPlugin"]
+plugins=["LineaEstimateGasEndpointPlugin","L1FinalizationTagUpdaterPlugin"]
 plugin-linea-module-limit-file-path="config/trace-limits.sepolia.toml"
 plugin-linea-max-tx-calldata-size=60000
 plugin-linea-max-block-calldata-size=70000
@@ -89,5 +89,8 @@ plugin-linea-extra-data-pricing-enabled=true
 plugin-linea-extra-data-set-min-gas-price-enabled=true
 plugin-linea-l1l2-bridge-contract="0x33bf916373159A8c1b54b025202517BfDbB7863D"
 plugin-linea-l1l2-bridge-topic="e856c2b8bd4eb0027ce32eeaf595c21b0b6b4644b326e5b7bd80a1cf8db72e6c"
+
+# L1FinalizationTagUpdaterPlugin
 plugin-linea-l1-polling-interval="PT12S"
-plugin-linea-l1-smart-contract-address="0xB218f8A4Bc926cF1cA7b3423c154a0D627Bdb7E5"
+plugin-linea-l1-smart-contract-address="0xB218f8A4Bc926cF1cA7b3423c154a0D627Bdb7E5"
+plugin-linea-l1-rpc-endpoint="http://localhost:8545"