Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible compatibility issue between Constraitns and Corset #229

Closed
gusiri opened this issue Jun 4, 2024 · 3 comments
Closed

possible compatibility issue between Constraitns and Corset #229

gusiri opened this issue Jun 4, 2024 · 3 comments
Assignees

Comments

@gusiri
Copy link
Contributor

gusiri commented Jun 4, 2024

Getting this error when make define.go under zkevm-monorepo/constraints
Possibly compatibility issue between constraints and corset

Could be related to https://github.com/Consensys/zkevm-monorepo/issues/3326 @ivokub

Related issue: #143

environment:
constraints: v0.1.0-prover-integration
corset: v9.7.10, master branch (c729dbce)

...
[INFO] Parsing txndata_into_blockdata.lisp
[INFO] Parsing txndata_into_rlptxrcpt.lisp
[INFO] Parsing txndata_into_rlpaddr.lisp
[INFO] Parsing wcp/columns.lisp
[INFO] Parsing wcp/constraints.lisp
[ERROR] parsing `Immediate expression`

Caused by:
     --> 1:1
      |
    1 | define
      | ^---
      |
      = expected corset
[INFO] Compiling into constraint set, Elapsed=1.682057412s
Error: 1 errors found
make[1]: *** [Makefile:130: define.go] Error 1
make[1]: Leaving directory '/home/gusiri/zkevm-monorepo/constraints'
make: *** [Makefile:55: zkevm/define/define.go] Error 2
@gusiri
Copy link
Contributor Author

gusiri commented Jun 4, 2024

make define.go without define in the Makefile

define.go: ${ZKEVM_MODULES}
	${CORSET} wizard-iop -vv -o $@ ${ZKEVM_MODULES}

removed the previously mentioned error but we have another error:

thread 'main' panicked at src/exporters/wizardiop.rs:118:21:
Exponent `4222230874714185212124412469390773265687949667577031913967616727958704619521` is too large
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
make: *** [Makefile:130: define.go] Error 101

@gusiri
Copy link
Contributor Author

gusiri commented Jun 4, 2024

In constraints/Makefile,

define.go: ${ZKEVM_MODULES}
	${CORSET} wizard-iop -vv -o $@ ${ZKEVM_MODULES}

to

define.go: ${ZKEVM_MODULES}
	../corset/target/release/corset wizard-iop -vv -o $@ ${ZKEVM_MODULES}

fixed it.
Seems like we have a bug here, when we use ${CORSET}?

I checked that I have the latest corset and constraints.
Also checked that command corsetpoints to zkevm-monorepo/corset/target/release/corset correctly.

@gusiri
Copy link
Contributor Author

gusiri commented Jun 5, 2024

Close as it has been narrowed down to :
Consensys/corset#173
#230

@gusiri gusiri closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants