You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found that using CORSET ?= corset and ${CORSET} in the Makefile can be problematic. It relies on the existence of an executable named "corset" in the current working directory, which can lead to conflicts with older versions or other executables with the same name (e.g., old executable generated by cargo install --path.).
This fixes issue #143
which might be caused by ${CORSET} looking at another executable instead of ../corset/target/release/corset
Proposed solution:
Let's change this to a specific path ../corset/target/release/corset, similar to how it's done in prover/Makefile. This ensures the Makefile always uses the intended executable from a clear location.
For example, this will simply fix problems caused by corset executable conflicts
CORSET=$HOME/corset make -B zkevm.bin
shell: /usr/bin/bash -e {0}
make: ../corset/target/release/corset: No such file or directory
make: *** [Makefile:169: zkevm.bin] Error 127
gusiri
changed the title
Use a specific path in Makefile to avoid corset executable conflicts
Use a relative path in Makefile to avoid corset executable conflicts
Jun 4, 2024
Current issue:
I found that using
CORSET ?= corset
and${CORSET}
in the Makefile can be problematic. It relies on the existence of an executable named "corset" in the current working directory, which can lead to conflicts with older versions or other executables with the same name (e.g., old executable generated bycargo install --path.
).This fixes issue #143
which might be caused by
${CORSET}
looking at another executable instead of../corset/target/release/corset
Proposed solution:
Let's change this to a specific path
../corset/target/release/corset
, similar to how it's done inprover/Makefile
. This ensures the Makefile always uses the intended executable from a clear location.For example, this will simply fix problems caused by corset executable conflicts
The text was updated successfully, but these errors were encountered: