fix(rlpTxn): constraint ADDR during AccessList tuple & ChainId #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
OlivierBBB
reviewed
Sep 26, 2024
rlptxn/constraints.lisp
Outdated
| (remained-constant! ADDR_LO)))) | ||
| (if-not-zero (* [DEPTH 1] (- nADDR (- (prev nADDR) 1))) | ||
| (begin (remained-constant! ADDR_HI) | ||
| (remained-constant! ADDR_LO)))) |
There was a problem hiding this comment.
I'm not following how this maps to
There was a problem hiding this comment.
I guess this relates to this spec update: https://github.com/Consensys/linea-specification-internal/pull/618
There was a problem hiding this comment.
My next question would be: are special precautions required for the first row of IS_PHASE_ACCESS_LIST = 1 ?
There was a problem hiding this comment.
No, the first row of ACCESS£LIST PHASE has DEPTH_1 = 0, so it's OK.
There was a problem hiding this comment.
see
…-be-constant-along-accesslist-tuple
letypequividelespoubelles
changed the title
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
OlivierBBB
approved these changes
Sep 27, 2024
letypequividelespoubelles
deleted the
402-rlp_txn-addr_hilo-is-not-constraint-to-be-constant-along-accesslist-tuple
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec : https://github.com/Consensys/linea-specification-internal/pull/620 & https://github.com/Consensys/linea-specification-internal/pull/618