Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of the HUB / MXP interface bug fix #468

Closed
wants to merge 5 commits into from
Closed

Implementation of the HUB / MXP interface bug fix #468

wants to merge 5 commits into from

Conversation

lorenzogentile404
Copy link
Contributor

@lorenzogentile404 lorenzogentile404 commented Oct 24, 2024 •
edited by OlivierBBB
Loading

@lorenzogentile404 lorenzogentile404 linked an issue Oct 24, 2024 that may be closed by this pull request
HUB/MXP bug: zero size, enormous offsets => type issue in the HUB #467
Open
OlivierBBB
OlivierBBB requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@OlivierBBB OlivierBBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was also a change made to the way we compute T4MTNTOP.

mxp/columns.lisp Outdated Show resolved Hide resolved
mxp/constraints.lisp Outdated Show resolved Hide resolved
OlivierBBB
OlivierBBB approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@OlivierBBB OlivierBBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlivierBBB OlivierBBB changed the title fix(mxp): add S1NZNOMXPX and S2NZNOMXPX Implementation of the HUB / MXP interface bug fix Oct 24, 2024
@OlivierBBB OlivierBBB added the bug Something isn't working label Oct 24, 2024
OlivierBBB
OlivierBBB reviewed Oct 24, 2024
View reviewed changes
mxp/columns.lisp Outdated
@@ -42,6 +42,13 @@
(LIN_COST :i64)
(GAS_MXP :i64)
(EXPANDS :binary@prove)
(MTNTOP :binary@prove))
(T4MTNTOP :binary@prove)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo here.

@OlivierBBB OlivierBBB closed this Oct 24, 2024
@OlivierBBB OlivierBBB deleted the 467-hubmxp-bug-zero-size-enormous-offsets-=-type-issue-in-the-hub branch October 24, 2024 20:19
@OlivierBBB OlivierBBB restored the 467-hubmxp-bug-zero-size-enormous-offsets-=-type-issue-in-the-hub branch October 25, 2024 17:51
@OlivierBBB OlivierBBB reopened this Oct 25, 2024
@OlivierBBB OlivierBBB closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierBBB OlivierBBB OlivierBBB approved these changes

Assignees

@lorenzogentile404 lorenzogentile404

@OlivierBBB OlivierBBB

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HUB/MXP bug: zero size, enormous offsets => type issue in the HUB
2 participants
@lorenzogentile404 @OlivierBBB