BLOCKDATA redesign #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBBB
requested review from
lorenzogentile404,
amkCha and
letypequividelespoubelles
and removed request for
lorenzogentile404
The lookup must land among the rows where CURRENT_CONFLATION = 1
The lookup must land among the rows where CURRENT_CONFLATION = 1
| \item $\isGaslimit$ | ||
| \item $\isChainid$ | ||
| \end{enumerate} | ||
| \end{multicols} |
There was a problem hiding this comment.
IS_BASEFEE is missing.
| \isGaslimit & \longleftrightarrow & \locIsGaslimit \\ | ||
| \isChainid & \longleftrightarrow & \locIsChainid \\ | ||
| \isBasefee & \longleftrightarrow & \locIsBasefee \\ | ||
| \end{array} \right. |
There was a problem hiding this comment.
I suggest to defined those as aliases of columns names using: https://www.notion.so/consensys/Naming-Conventions-55b293749c9a459eaef5c96d7f982267?pvs=4#91deab67ed894ae78b1311beb8380443.
amkCha
reviewed
Dec 9, 2024
| \blockDataLo _{i} & = & \coinbase\low _{i} \\ | ||
| \end{array} \right. | ||
| \] | ||
| \item[\underline{\underline{\inst{GASLIMIT} deviation lower bound:}}] |
There was a problem hiding this comment.
Should it be ?
\item[\underline{\underline{\inst{COINBASE} lower bound:}}]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign of the
BLOCKDATAmoduleBLOCKGASLIMITto change in accordance with the yellow paper