Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent variable name casing #165

Open
larsgw opened this issue Jul 10, 2017 · 0 comments
Open

Use consistent variable name casing #165

larsgw opened this issue Jul 10, 2017 · 0 comments

Comments

@larsgw
Copy link

larsgw commented Jul 10, 2017

This may be a bit nitpicky, but if you're using standard, you should also use camelCase, even if the linter has a hard time enforcing that rule. Example:

if (eupmc.hitlimit - eupmc.allresults.length < eupmc.pagesize) {
  eupmc.residualhits = eupmc.hitlimit - eupmc.allresults.length
}

Whereas the next line does use camelCase.

eupmc.nextCursorMark = resp.nextCursorMark[0]

https://github.com/ContentMine/getpapers/blob/master/lib/eupmc.js#L160-L163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant