Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings in amqp-cpp that are treated as errors in our build #399

Open
alagiz opened this issue Jun 30, 2021 · 3 comments
Open

warnings in amqp-cpp that are treated as errors in our build #399

alagiz opened this issue Jun 30, 2021 · 3 comments

Comments

@alagiz
Copy link

alagiz commented Jun 30, 2021

hello.

we are using AMQP-CPP library in our project and having troubles building it, because several headers have warnings in them, and they are treated as errors:

at

envelope.h line 68
envelope.h line 125
libevent.h line 67
C:\...\.conan\data\amqp-cpp\4.3.11\_\_\package\8cf01e2f50fcd6b63525e70584df0326550364e1\include\amqpcpp/envelope.h(68): warning C4244: 'argument': conversion from 'uint64_t' to 'uint32_t', possible loss of data 
...\include\amqpcpp/envelope.h(125): warning C4244: 'argument': conversion from 'const uint64_t' to 'uint32_t', possible loss of data (compiling source file ...) 
...\include\amqpcpp/libevent.h(67): warning C4244: 'argument': conversion from 'intptr_t' to 'int', possible loss of data (compiling source file ..) 

we believe it is a good practice to treat warnings as errors.
could you please fix those?

@rwols
Copy link
Contributor

rwols commented Aug 3, 2021

should be fixed by #412

@EmielBruijntjes
Copy link
Member

Is this still an issue?

@SebDieBln
Copy link
Contributor

SebDieBln commented Apr 25, 2022

Is this still an issue?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants