Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection_name property is not set on windows platform #507

Open
olejniczak opened this issue Aug 24, 2023 · 2 comments
Open

connection_name property is not set on windows platform #507

olejniczak opened this issue Aug 24, 2023 · 2 comments

Comments

@olejniczak
Copy link
Contributor

connectionstartframe.h:231

#if defined(_WIN32) || defined(_WIN64) // i don't know that much about win32, so let's use hardcoded string if (!properties.contains("product")) properties["product"] = "application based on AMQP-CPP"; if (!properties.contains("platform")) properties["platform"] = "windows"; #else // on unix-like systems I know how to retrieve application and platform info if (!properties.contains("product")) properties["product"] = ProgramName(); if (!properties.contains("platform")) properties["platform"] = PlatformName(); if (!properties.contains("connection_name")) properties["connection_name"] = ProgramName(); #endif

@EmielBruijntjes
Copy link
Member

pull request?

@olejniczak
Copy link
Contributor Author

I'm just looking for a quick and clean solution.

olejniczak added a commit to olejniczak/AMQP-CPP that referenced this issue Aug 24, 2023
olejniczak added a commit to olejniczak/AMQP-CPP that referenced this issue Aug 24, 2023
EmielBruijntjes added a commit that referenced this issue Aug 24, 2023
#507 connection_name property is not set on windows platform
olejniczak added a commit to olejniczak/AMQP-CPP that referenced this issue Aug 24, 2023
EmielBruijntjes added a commit that referenced this issue Aug 24, 2023
#507 connection_name property is not set on windows platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants