From 8efba8210a4038b014633ea66ca2485d75c11109 Mon Sep 17 00:00:00 2001
From: Nick Moore <nick@zoic.org>
Date: Thu, 28 Mar 2024 09:49:45 +1100
Subject: [PATCH] orientation for "no inputs" / "no outputs" bars

---
 countess/gui/icons/hbar.gif | Bin 0 -> 62 bytes
 countess/gui/icons/vbar.gif | Bin 0 -> 71 bytes
 countess/gui/tree.py        |  36 ++++++++++++++++++++++--------------
 3 files changed, 22 insertions(+), 14 deletions(-)
 create mode 100644 countess/gui/icons/hbar.gif
 create mode 100644 countess/gui/icons/vbar.gif

diff --git a/countess/gui/icons/hbar.gif b/countess/gui/icons/hbar.gif
new file mode 100644
index 0000000000000000000000000000000000000000..9c36a0bcf7ddd446c3fe90cb900a0aa5b685a1e8
GIT binary patch
literal 62
zcmZ?wbhEHblwjasXkcXc&%nU8rd#nR3nLc;BZCeD5P)PDm_&Q}SDx-=SUg8$M%U}J
PGVkVDKJt)bWv~VSx%3dl

literal 0
HcmV?d00001

diff --git a/countess/gui/icons/vbar.gif b/countess/gui/icons/vbar.gif
new file mode 100644
index 0000000000000000000000000000000000000000..a2d12046b127b3a9257c89c3ddf360826a5f8449
GIT binary patch
literal 71
zcmZ?wbhEHb<Y16sXkcXc&%nU8rd#nR3nLc;BZCeD5P)PDnB;o;7fiVQ>qg|I3mwZZ
ZPq<!CIdkj8xj$Q9a7=sKDZ|QO4FI<d7_$HX

literal 0
HcmV?d00001

diff --git a/countess/gui/tree.py b/countess/gui/tree.py
index 3b28ead..531d175 100644
--- a/countess/gui/tree.py
+++ b/countess/gui/tree.py
@@ -253,16 +253,22 @@ def __on_configure(self, event):
 class DraggableLabel(DraggableMixin, FixedUnbindMixin, tk.Label):
     pass
 
+
 class NodeWrapper(DraggableLabel):
 
-    def update_node(self, node):
-        left_bar = node.plugin and node.plugin.num_inputs == 0
-        right_bar = node.plugin and node.plugin.num_outputs == 0
-        self.configure(
-            text=node.name,
-            image=get_icon(self, "redbar") if left_bar or right_bar else None,
-            compound = tk.LEFT if left_bar else tk.RIGHT,
-        )
+    def update_node(self, node, vertical=False):
+        input_bar = node.plugin and node.plugin.num_inputs == 0
+        output_bar = node.plugin and node.plugin.num_outputs == 0
+        if not input_bar and not output_bar:
+            image = None
+            compound = tk.NONE
+        elif vertical:
+            image=get_icon(self, "hbar")
+            compound = tk.TOP if input_bar else tk.BOTTOM
+        else:
+            image=get_icon(self, "vbar")
+            compound = tk.LEFT if input_bar else tk.RIGHT
+        self.configure( text=node.name, image=image, compound=compound)
 
 
 class GraphWrapper:
@@ -292,7 +298,6 @@ def __init__(self, canvas, graph, node_select_callback):
 
     def label_for_node(self, node):
         label = NodeWrapper(self.canvas, wraplength=125, cursor="hand1", takefocus=True)
-        label.update_node(node)
         if not node.position:
             node.position = (random.random() * 0.8 + 0.1, random.random() * 0.8 + 0.1)
         # XXX should be more elegant way of answering the question "are we flipped?"
@@ -338,14 +343,16 @@ def on_mousedown(self, node, event):
 
     def on_configure(self, node, label, event):
         """Stores the updated position of the label in node.position"""
-        xx = float(label.place_info()["relx"]) * self.canvas.winfo_width()
-        yy = float(label.place_info()["rely"]) * self.canvas.winfo_height()
+        height = self.canvas.winfo_height()
+        width = self.canvas.winfo_width()
+
+        xx = float(label.place_info()["relx"]) * width
+        yy = float(label.place_info()["rely"]) * height
         node.position = self.new_node_position(xx, yy)
+        label.update_node(node, width < height)
 
         # Adapt label sizes to suit the window size, as best we can ...
         # XXX very arbitrary and definitely open to tweaking
-        height = self.canvas.winfo_height()
-        width = self.canvas.winfo_width()
         if height > width:
             label_max_width = max(width // 9, 25)
             label_font_size = int(math.sqrt(width) / 3)
@@ -530,7 +537,8 @@ def del_parent(self, parent_node, child_node):
     def node_changed(self, node):
         """Called when something external updates the node's name, status
         or configuration."""
-        self.labels[node].update_node(node)
+        flipped = self.canvas.winfo_width() >= self.canvas.winfo_height()
+        self.labels[node].update_node(node, not flipped)
 
     def destroy(self):
         for node_lines in self.lines.values():