-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash with double-free, on response.end() in another thread, on v1.1, v.1.2, and master #843
Comments
If I remenber correctly, async calls are not supported in the current version, but I have to look up, where I found that. |
I know its not fully supported, but trying to understand #258, it sounds like the main problem has been that I'd the handling of the incoming HTTP request might block, but even that seems to have been solved. (And even if it hasnt, I can live with that for now, since my HTTP server is fairly low volume, for now). But a 100% crash scenario, that's a different story. Even more strange, this works fine (as far as I can see, that is), in v1.0+5. Its the later versions, where afaik the standalone asio is used instead of full boost, that the problem starts....(?) |
I don't think that's the asio version is the problem, I fear there was a change in the order of closing things which may have caused that. |
Any progress on this? I've been trying to use -DCROW_USE_BOOST=ON in the meantime, but that gives me all sorts of compilation errors on opensuse, so I am a bit stuck. |
Just as a note that I have tried this on later versions in master, with the same problems. |
async calls are not supported in versions > 1.0.5. |
Hi,
I'm trying to move from v.1.0+5, but it seems that my use of asynchronous responses will always crash. I know that async is still "in development", but from trying to follow: #258, it doesn't feel like this kind of crash is what should be happening.
In my ROUTE's, I am rarely able to return a valid HTTP response directly (but in the cases I can, no crashes at all).
If I instead, save a reference (not std::move) to the crow::response, and after my 3pp asynchronous API returns via another thread, I do:
It will crash every time. According to traces my
m_response.is_alive() == true
, but then it crashes. Below trace is when compiled with-fsanitize=address
, but I just used that to get more detailed crash info.The text was updated successfully, but these errors were encountered: