Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http response: compressed flag can't not be set to false? #848

Open
D-Latch opened this issue Jul 10, 2024 · 2 comments
Open

Http response: compressed flag can't not be set to false? #848

D-Latch opened this issue Jul 10, 2024 · 2 comments
Labels
bug Something isn't working discussion The viability / implementation of the issue is up for debate

Comments

@D-Latch
Copy link

D-Latch commented Jul 10, 2024

Hi in this issue 'Added HTTP compression using gzip or deflate #93' you said:
'I think for now it's best to disable gzip when streaming a response (whether it's static files or large responses), maybe will be added with websocket compression'

No matter how I set 'compressed' flag to false I still find header 'Content-Encoding' in my response. So I assumed that the authentic response returned is not the one I define but the one that is copied from it. Thus I thought compressed flag might forgot to be set in the copy-construct function and finally I got this:

2024-07-10_10-40

@gittiver gittiver added bug Something isn't working discussion The viability / implementation of the issue is up for debate labels Jul 10, 2024
@gittiver
Copy link
Member

looks like a bug. any comments on this?

@D-Latch
Copy link
Author

D-Latch commented Jul 11, 2024

Well, I'm not so sure because I think if it's a problem then it should have been found long time ago.
However, there is a git comment bound to the param 'filei_nfo' saying: ' fix move assign operator not moving file_info'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussion The viability / implementation of the issue is up for debate
Projects
None yet
Development

No branches or pull requests

2 participants