Remove Salutation and Closing from email notification

[ok236449]

When you send a notification on the dashboard, you may face the issue of doubling these.

Steps to reproduce the behavior:
Let's say, you want to notify a user by both email and dashboard notifications. You create a notification something like this:

On dashboard, the notification would be sent normally, just like you wrote it.

The mail would have 2 salutations and 2 closings.

Expected behavior
The automatic salutation and closing should be removed from these notification emails, but kept on the other mails(reset password, ...)

Adding the salutation to dashboard notifications would work, but that is not the best way of fixing this. Removing the salutation from mail is a way better idea as it allows for customizability and if you were to notify someone, you would definitely write them on your own.

[S0ly]

have this been fixed since ?

[GeckoBoy84]

No

[MrWeez]

Am I missing something? I see in the message only the text that you wrote. Or do you mean to completely remove the greeting and ending from the email template for notifications?

[S0ly]

idk if you can test if the issues is still here so we can ethier fix or close this issue it could be great @MrWeez ! :)

[MrWeez]

idk if you can test if the issues is still here so we can ethier fix or close this issue it could be great @MrWeez ! :)

Although, I have an idea. We can add a greeting to the notification template in the dashboard.

[MrWeez]

Then we won't have to write a greeting in the notification text.

[S0ly]

what ? there is just no need for a greeting why a "hello" is by default and non removable in the template ? xD

[S0ly]

I dont have working mail so I cannot check but the hello just need to be removed

[S0ly]

like it make no sense to use a template on a custom mail

[MrWeez]

like it make no sense to use a template on a custom mail

Ok, I will try to solve this problem. I'll assign myself for now so I don't forget.

[S0ly]

it should be pretty easy to fix I just dont have time for it since it a medium priority and I cannot test it
but yeah fixing it should be easy and nice to not have this problem
thanks weez :)

[MrWeez]

it should be pretty easy to fix I just dont have time for it since it a medium priority and I cannot test it but yeah fixing it should be easy and nice to not have this problem thanks weez :)

If you want, I can give you an smtp account for testing xD

[S0ly]

no thanks weez xD

[MrWeez]

no thanks weez xD

I couldn't get the job off on you 😂😂

[S0ly]

weez you dont feel I have enough pressure on me ? xD

[MrWeez]

weez you dont feel I have enough pressure on me ? xD

I'm kidding. You already have a lot of tasks

[S0ly]

this is more complex than initially viewed and maybe needs refactoring of how the mails works