Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inconsistencies in role names. #958

Closed
Tracked by #952
kenshin133 opened this issue May 22, 2024 · 0 comments · Fixed by #952
Closed
Tracked by #952

[Bug]: Inconsistencies in role names. #958

kenshin133 opened this issue May 22, 2024 · 0 comments · Fixed by #952
Labels
Bug / Fix Something isn't working and may need a fix High Priority Critical. Act quickly for resolution

Comments

@kenshin133
Copy link

kenshin133 commented May 22, 2024

What is your request about?

403
USER DOES NOT HAVE THE RIGHT PERMISSIONS.

was found while trying to add sane permissions for the "support staff" role.

I notice the error I see is that admin.tickets.read is missing, but that perm does not exist. I DO have admin.ticket.read

image

Branch

dev

Solution idea

I think a sweeping change to make sure some of these are standardized should do it. it looks like logic wise its working. but just the wrong name.

The SPECIFIC fix for this one would be in Http/Controllers/Admin/TicketsController.php

This inconsistency also goes as far as the database

image

Ctrlpanel Logs

no logs needed

Additional Info

UPDATE permissions SET name="admin.tickets.read" where id=6; plus changing all instances of admin.ticket.read in all files fixed this.
ily

@S0ly S0ly added Bug / Fix Something isn't working and may need a fix High Priority Critical. Act quickly for resolution labels May 22, 2024
@S0ly S0ly linked a pull request May 22, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Fix Something isn't working and may need a fix High Priority Critical. Act quickly for resolution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants