feat: 2FA Progress Sync #920
Conversation
AGuyNamedJens
added
Feature
|
How would it links to ptero 2fa? |
I don't have enough knowledge about how Pterodactyl does it, I honestly don't think we can just hook into their 2FA system because that can basically beat the whole security logic of 2FA |
yeah please don't what would the point be then? |
|
no update since 2023 ? |
Feel free to provide your own update, I'm clueless at this point which is why I request other contributions to join in |
| } | ||
|
|
||
| // Create a new secret and display the QR code | ||
| public function Attempt2FA() |
There was a problem hiding this comment.
attempt2Fa()
Use one function naming style bcs lower is for example isValidRecoveryKey
| * @param string $value | ||
| * @return \Illuminate\Database\Eloquent\Casts\Attribute | ||
| */ | ||
| protected function google2faSecret(): Attribute |
There was a problem hiding this comment.
U can use encrypted cast without this
S0ly
added
Low Priority
|
I tried to resolve the conflict that was whit .gitignore hope I didnt missed anything |
|
what we do of this pull request since its totally inactive and not finished ? |
I guess no one wants it implemented? I got stuck at the moment of login methods, as previously discussed it's due to how we still depend on Laravel/ui which makes integration impossible with 2FA |
|
personally it would be interesting me to have this but its not currently on my priority list :) |
|
we should close the PR if no one is gonna do it, it will be available for reopen later |
I agree. |
Managed to get 2FA integration working, it yet has to be connected to the actual login method for users. Feel free to debug, change it or whatever. Basics are implemented.
See:
app/Http/Controllers/Auth/Login2FAController.php
app/Http/Controllers/LoginCheckpointController.php
app/Http/Controllers/Kernel.php
app/Http/Models/RecoveryToken.php
app/Http/Models/User.php
database/UserFactory.php
routes/web.php
themes/default/views/auth/2fa-secret.blade.php
composer.json
For my changes