We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the DQNAgent, particularly in the step method, there seems to be a potential issue in properly distinguishing between termination and truncation, as suggested by the Gymnasium documentation available at https://gymnasium.farama.org/tutorials/gymnasium_basics/handling_time_limits/.
The following line of code, done = terminated or truncated, treats both termination and truncation equally.
done = terminated or truncated
Furthermore, in the _compute_dqn_loss method, the code lines: mask = 1 - done target = (reward + self.gamma * next_q_value * mask).to(self.device)
mask = 1 - done target = (reward + self.gamma * next_q_value * mask).to(self.device)
do not seem to account specifically for truncation.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
In the DQNAgent, particularly in the step method, there seems to be a potential issue in properly distinguishing between termination and truncation, as suggested by the Gymnasium documentation available at https://gymnasium.farama.org/tutorials/gymnasium_basics/handling_time_limits/.
The following line of code,
done = terminated or truncated, treats both termination and truncation equally.Furthermore, in the _compute_dqn_loss method, the code lines:
mask = 1 - done target = (reward + self.gamma * next_q_value * mask).to(self.device)do not seem to account specifically for truncation.
The text was updated successfully, but these errors were encountered: