Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Timestamp Representation in XML and JSON BOM Files #877

Closed
eugenhoffmann opened this issue May 21, 2024 · 3 comments
Closed
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@eugenhoffmann
Copy link

eugenhoffmann commented May 21, 2024

I have noticed that the timestamp representation in the XML and JSON BOM files is inconsistent. While both formats are ISO 8601 conform, the XML BOM file contains a timestamp with a precision of up to 7 decimal places for the seconds fraction:

  • XML: 2024-05-17T15:50:31.6823708+00:00
  • JSON: 2024-05-17T15:50:31Z

In my opinion, this level of precision is not necessary. Furthermore, the second fractions more than 3 digits are not supported by the Python API datetime.fromisoformat(date_string) method.

While these differences are not incorrect, they can be confusing and may cause issues when processing the data. I would like to propose that we adopt a consistent timestamp representation across both file formats, ideally using the JSON timestamp format.

Thank you for considering this issue!

@github-actions github-actions bot added the triage Don't know what to do with this yet label May 21, 2024
@mtsfoni
Copy link
Contributor

mtsfoni commented May 21, 2024

This is most likely an issue for the CycloneDX dotnet library where the serialization actually happens.

Could you open this issue also there?
Once fixed in the library, I will create a new version of the generating tool.

@mtsfoni mtsfoni added enhancement New feature or request wontfix This will not be worked on and removed triage Don't know what to do with this yet labels May 21, 2024
@eugenhoffmann
Copy link
Author

Thank you for your response. I have opened an Issue in the CycloneDX dotnet library as suggested

@mtsfoni
Copy link
Contributor

mtsfoni commented May 28, 2024

Should be resolved in 3.0.7. Let me know if you still have problems

@mtsfoni mtsfoni closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants