Refactor program class to increase testability #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CodeTiger <mibau89@gmail.com>
Signed-off-by: CodeTiger <mibau89@gmail.com>
Signed-off-by: CodeTiger <mibau89@gmail.com>
Signed-off-by: CodeTiger <mibau89@gmail.com>
This reverts commit 4d4059b. Signed-off-by: CodeTiger <mibau89@gmail.com>
mtsfoni
force-pushed
the
refactorProgramClass
branch
from
8725589
to
fc76c9b
Compare
Signed-off-by: CodeTiger <mibau89@gmail.com>
…oud/cyclonedx-dotnet into refactorProgramClass
Signed-off-by: CodeTiger <mibau89@gmail.com>
Signed-off-by: CodeTiger <mibau89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will improve testability. For example, the services will not be static dependencies any more, making parallel tests with different mock-services possible.
It will also be easier to use CycloneDX as a library because the running logic is now decoupled from the CLI-parameters.