From c08b9c77c204e441a0540a5e6695668fe2c8b9a2 Mon Sep 17 00:00:00 2001 From: mtgag Date: Tue, 12 Sep 2023 10:07:58 +0200 Subject: [PATCH] addressing issue #388. Checking if URL is null, empty, or blank (using Java 1.8 compatibility) Signed-off-by: mtgag --- .../java/org/cyclonedx/maven/DefaultModelConverter.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/cyclonedx/maven/DefaultModelConverter.java b/src/main/java/org/cyclonedx/maven/DefaultModelConverter.java index d462ac67..b8aaa200 100644 --- a/src/main/java/org/cyclonedx/maven/DefaultModelConverter.java +++ b/src/main/java/org/cyclonedx/maven/DefaultModelConverter.java @@ -269,7 +269,7 @@ private MavenProject getEffectiveMavenProject(final Artifact artifact) throws Pr } private void addExternalReference(final ExternalReference.Type referenceType, final String url, final Component component) { - if (url == null || doesComponentHaveExternalReference(component, referenceType)) { + if (isURLBlank(url) || doesComponentHaveExternalReference(component, referenceType)) { return; } try { @@ -398,4 +398,8 @@ private Component.Type resolveProjectType(String projectType) { } return Component.Type.LIBRARY; } + + private static boolean isURLBlank(String url) { + return url == null || url.isEmpty() || url.trim().length() == 0; + } }