Please give us feedback and improvement points!

[PatrickAlphaC]

In this thread, please leave feedback on your favorite parts, and least favorite parts of the course!

This way, we can keep updating so we can make Cyfrin Updraft easier and easier for you to learn.

CURRENT FEEDBACK POINTS:

• Quizzes
• More challenges

[KeySkills]

In Advanced Foundry Course, Section 3 - Develop Defi Protocol Lesson 16: DSCEngine advanced testing and Lesson 17: Write fuzz tests and contain the same video.

[PatrickAlphaC]

Thanks! We will fix.

[Aaryan-Urunkar]

First of all, a supreme effort and a mega thanks to the Cyrfin team and @PatrickAlphaC sir for creating this course! I just had a few pieces of feedback:

1. The ERC-20 token and the NFT part seemed a bit rushed, which I don't know why put me off from finishing video 2(or even touching the course) for nearly a week. I don't know if it was just me or anybody else as well, but yeah, thought of putting it down here.

2. Secondly, I had migrated to this course after watching nearly 8 hours of the Hardhat one from freecodecamp which is outdated and hence I found it difficult to follow that one. It would be VERY VERY appreciated if the team could do a similar frontend course. Even if it isn't an entire mammoth course with the new updated Hardhat but just the frontend part for some of the existing foundry projects from this course, I would appreciate it, and I think many others would too!

Thankyou again!!!

[PatrickAlphaC]

ERC-20 token and the NFT part seemed a bit rushed

Thanks for this feedback! Which parts would you have wished we went over deeper / slower so it would feel less rushed?

a similar frontend course.

This year ;)

[Aaryan-Urunkar]

The parts I feel you should have dived deeper into is definitely during the ERC20 intro section. I left that section feeling doubtful if I understood it or not but yeah, during DSC, I had to google a lot of stuff abt ERC-20 which I previously was unclear about. Hence I feel that the ERC-20 section can slightly be improved so that by DSC everyone has a better idea abt what ERC-20s are.

Very hyped up for the frontend course sir!! Already know it's gonna be a bombshell as soon as it is out! In the meanwhile, just gonna build up project from whatever I have learned so far.

EDIT: Thanks to this course I ended up with my first ever answer on stack overflow lol! (https://stackoverflow.com/a/78801142)

[bibhashdash]

Thanks for the course it's really good. I was wondering, is there a way to flag (or bookmark) a specific video so that we can easily come back to it later? I know we can leave it 'unchecked' but perhaps a quicker way would be to maybe filter and find all the bookmarked ones.
Anyway, just a thought. Great work on the course and looking forward to continuing my journey in web3.

[PatrickAlphaC]

Oooo interesting. Good feature request!

[SiewLin-AIDeaBuddy]

Thanks a lot for the excellent educative course materials. The option to learn sectioned videos in Updraft instead of a combined long hours video is greatly appreciated. Would like to give generic improvement feedbacks as below:

1. To include feature where user can easily take notes at any timestamp of the course tutorial videos in order to further deep dive on certain topics at later stage or to jot down topics that need attention. User can also easily view/search those notes made at various timestamps to revise the topics again instead of searching and rewatching the entire video to find the one that is relevant to revise.

2. It would be very helpful if after each new topic, a relevant past audit case study with solution or actual hacked protocols walk through is included at the end / or at the right time junction within the course to further enhance the understanding and applicability of the topic in real case.

3. Similar to 2 above, at the end of several topics/chapters/modules, if there is a relevant section in first flight / audits that closer to the taught topics, the inclusion of those info can be added apart from any planned challenges/quizzes. This is especially useful for those who just started in the field to get closer to something that they can attempt to after the lesson to test out their understanding of the topic rather than hunting around the various sources to find out that the real test/audit is far beyond from what they have learned at that point, and couldn’t really apply due to lots of missing pieces of associated knowledge. Perhaps can utilize / modify past first flight/audit to cater the learning needs/tests for targeted topics, this makes the learning more effective as it is closer to actual applications.

[EngrPips]

Interesting feedback.

[mpuj99]

Thanks for this course Patrick, it was amazing. Really well explained.
Two things I noticed during these course:

1. In section 3 - Develop DEFI protocol, in Lesson 20: Create the collateral redeem handler, when you create the line to get the collateral of a user:

uint256 maxAmountCollateralToRedeem = engine.getCollateralDepositedOfUser(sender, address(collateral));

The function it has this order of arguments:

function getCollateralDepositedOfUser(address user, address token) external view returns(uint256)

First is the address of the user and then the address of the token, in the video you put first the token and then the user:

uint256 maxAmountCollateralToRedeem = engine.getCollateralDepositedOfUser(address(collateral), sender);

I suppose it doens't fail because both are addresses, I looked at the logs and when we console maxAmountCollateralToRedeem is equal to zero. So never fails, if you put it good the arguments it fails with the assertion failed:
(totalWethValue + totalWbtcValue) >= totalSupply in InvariantTest.t.sol
I tried to fix it but it was hard, because I think the problem was that we were depositing collateral, minting and redeeming but in that lesson we weren't burning so, I fixed only for 5 invariant executions, creating redeeming and burning in the same function, on the 6th execution found some value that cracked the healthFactor, so I gave up because I spent too much time on creating the function to redeem and burn at the same time. So just telling you, maybe you can fix it in a new video with the arguments good positioned.
But overall, just want to say that the DEFI protocol section was my favourite section of Advanced Foundry, I learned a lot.

2. Is a silly thing but, in the last section: Security, in the lesson 3: Top security tools, from the minute 9:23 till 9:34 is all black, is nothing but just saying maybe you didn't notice it.
   Thank you very much, amazing course. With eager to start hitting the security and auditing course!!!!

Regards,

[EngrPips]

Awesome Feedback, I trust he will reply to this as soon as he is available.