Advanced Foundry, Section 3 DeFi-StableCoin, Lesson 19 testRevertsIfMintedDscBreaksHealthFactor fails with the wrong error #2750

BowtiedHarpyEagle · 2024-10-26T07:18:55Z

BowtiedHarpyEagle
Oct 26, 2024

Hi, I'm going through the course, at lesson 19 of stablecoin. I am getting this error when I run the test:

$ forge test --mt testRevertsIfMintedDscBreaksHealthFactor 
[⠒] Compiling...
[⠘] Compiling 3 files with Solc 0.8.26
[⠃] Solc 0.8.26 finished in 1.58s
Compiler run successful!

Ran 1 test for test/DSCEngineTest.t.sol:DSCEngineTest
[FAIL: Error != expected error: ERC20: transfer amount exceeds balance != DSCEngine__HealthFactorTooLow(0)] testRevertsIfMintedDscBreaksHealthFactor() (gas: 116694)
Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 1.38ms (172.25µs CPU time)

Here is my test:

   function testRevertsIfMintedDscBreaksHealthFactor() public {
        (, int256 price,,,) = MockV3Aggregator(ethUsdPriceFeed).latestRoundData();
        amountToMint =
            (amountCollateral * (uint256(price) * dscengine.getAdditionalFeedPrecision())) / dscengine.getPrecision();
        vm.startPrank(user);
        ERC20Mock(weth).approve(address(dscengine), amountCollateral);

        uint256 expectedHealthFactor =
            dscengine.calculateHealthFactor(amountToMint, dscengine.getUsdValue(weth, amountCollateral));

        console.log("User WETH balance:", ERC20Mock(weth).balanceOf(USER));
        console.log("Amount collateral:", amountCollateral);
        console.log("Amount to mint:", amountToMint);
        console.log("Expected health factor:", expectedHealthFactor);

        vm.expectRevert(abi.encodeWithSelector(DSCEngine.DSCEngine__HealthFactorTooLow.selector, expectedHealthFactor));
        dscengine.depositCollateralAndMintDSC(weth, amountCollateral, amountToMint);
        vm.stopPrank();
    }

You can see the rest of my code here:

https://github.com/BowtiedHarpyEagle/advfoundry-03-defi-stablecoin/tree/196b1db9e9a7fb9b3140607d13dfa5ff2eb8c4d8

Verbose output with the trace:

$ forge test --mt testRevertsIfMintedDscBreaksHealthFactor -vvvv
[⠒] Compiling...
[⠘] Compiling 3 files with Solc 0.8.26
[⠃] Solc 0.8.26 finished in 1.61s
Compiler run successful!

Ran 1 test for test/DSCEngineTest.t.sol:DSCEngineTest
[FAIL: Error != expected error: ERC20: transfer amount exceeds balance != DSCEngine__HealthFactorTooLow(500000000000000000 [5e17])] testRevertsIfMintedDscBreaksHealthFactor() (gas: 117511)
Logs:
  User WETH balance: 10000000000000000000
  Amount collateral: 10000000000000000000
  Amount to mint: 24000000000000000000000
  Expected health factor: 500000000000000000

Traces:
  [10497440] DSCEngineTest::setUp()
    ├─ [4702604] → new DeployDSC@0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f
    │   └─ ← [Return] 23375 bytes of code
    ├─ [5589325] DeployDSC::run()
    │   ├─ [3731080] → new <unknown>@0x104fBc016F4bb334D775a19E8A6510109AC63E00
    │   │   ├─ [0] VM::startBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   ├─ [372255] → new <unknown>@0x90193C961A926261B756D1E5bb255e67ff9498A1
    │   │   │   └─ ← [Return] 1082 bytes of code
    │   │   ├─ [372255] → new <unknown>@0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496
    │   │   │   └─ ← [Return] 1082 bytes of code
    │   │   ├─ [658858] → new <unknown>@0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3
    │   │   │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: DeployDSC: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f], value: 100000000000 [1e11])
    │   │   │   └─ ← [Return] 2829 bytes of code
    │   │   ├─ [658858] → new <unknown>@0xDB8cFf278adCCF9E9b5da745B44E754fC4EE3C76
    │   │   │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: DeployDSC: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f], value: 100000000000 [1e11])
    │   │   │   └─ ← [Return] 2829 bytes of code
    │   │   ├─ [0] VM::stopBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   └─ ← [Return] 6894 bytes of code
    │   ├─ [934] 0x104fBc016F4bb334D775a19E8A6510109AC63E00::activeNetworkConfig() [staticcall]
    │   │   └─ ← [Return] 0x90193C961A926261B756D1E5bb255e67ff9498A1, 0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496, 0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3, 0xDB8cFf278adCCF9E9b5da745B44E754fC4EE3C76, 77814517325470205911140941194401928579557062014761831930645393041380819009408 [7.781e76]
    │   ├─ [0] VM::startBroadcast(<pk>)
    │   │   └─ ← [Return] 
    │   ├─ [741806] → new DecentralizedStableCoin@0x5FbDB2315678afecb367f032d93F642f64180aa3
    │   │   ├─ emit OwnershipTransferred(previousOwner: 0x0000000000000000000000000000000000000000, newOwner: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266)
    │   │   └─ ← [Return] 3361 bytes of code
    │   ├─ [875671] → new DSCEngine@0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512
    │   │   └─ ← [Return] 3696 bytes of code
    │   ├─ [2446] DecentralizedStableCoin::transferOwnership(DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512])
    │   │   ├─ emit OwnershipTransferred(previousOwner: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266, newOwner: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512])
    │   │   └─ ← [Stop] 
    │   ├─ [0] VM::stopBroadcast()
    │   │   └─ ← [Return] 
    │   └─ ← [Return] DecentralizedStableCoin: [0x5FbDB2315678afecb367f032d93F642f64180aa3], DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], 0x104fBc016F4bb334D775a19E8A6510109AC63E00
    ├─ [934] 0x104fBc016F4bb334D775a19E8A6510109AC63E00::activeNetworkConfig() [staticcall]
    │   └─ ← [Return] 0x90193C961A926261B756D1E5bb255e67ff9498A1, 0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496, 0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3, 0xDB8cFf278adCCF9E9b5da745B44E754fC4EE3C76, 77814517325470205911140941194401928579557062014761831930645393041380819009408 [7.781e76]
    ├─ [24728] 0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3::mint(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], 10000000000000000000 [1e19])
    │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], value: 10000000000000000000 [1e19])
    │   └─ ← [Stop] 
    └─ ← [Stop] 

  [117511] DSCEngineTest::testRevertsIfMintedDscBreaksHealthFactor()
    ├─ [8993] 0x90193C961A926261B756D1E5bb255e67ff9498A1::latestRoundData() [staticcall]
    │   └─ ← [Return] 1, 240000000000 [2.4e11], 1, 1, 1
    ├─ [270] DSCEngine::getPrecision() [staticcall]
    │   └─ ← [Return] 1000000000000000000 [1e18]
    ├─ [248] DSCEngine::getAdditionalFeedPrecision() [staticcall]
    │   └─ ← [Return] 10000000000 [1e10]
    ├─ [0] VM::startPrank(ECRecover: [0x0000000000000000000000000000000000000001])
    │   └─ ← [Return] 
    ├─ [24651] 0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3::approve(DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], 10000000000000000000 [1e19])
    │   ├─ emit Approval(owner: ECRecover: [0x0000000000000000000000000000000000000001], spender: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], value: 10000000000000000000 [1e19])
    │   └─ ← [Return] true
    ├─ [4596] DSCEngine::getUsdValue(0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3, 10000000000000000000 [1e19]) [staticcall]
    │   ├─ [993] 0x90193C961A926261B756D1E5bb255e67ff9498A1::latestRoundData() [staticcall]
    │   │   └─ ← [Return] 1, 240000000000 [2.4e11], 1, 1, 1
    │   └─ ← [Return] 24000000000000000000000 [2.4e22]
    ├─ [719] DSCEngine::calculateHealthFactor(24000000000000000000000 [2.4e22], 24000000000000000000000 [2.4e22]) [staticcall]
    │   └─ ← [Return] 500000000000000000 [5e17]
    ├─ [2607] 0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3::balanceOf(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D]) [staticcall]
    │   └─ ← [Return] 10000000000000000000 [1e19]
    ├─ [0] console::log("User WETH balance:", 10000000000000000000 [1e19]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] console::log("Amount collateral:", 10000000000000000000 [1e19]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] console::log("Amount to mint:", 24000000000000000000000 [2.4e22]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] console::log("Expected health factor:", 500000000000000000 [5e17]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] VM::expectRevert(custom error 0xf28dceb3: 00000000000000000000000000000000…00000000000000000000000000000000 (128 bytes))
    │   └─ ← [Return] 
    ├─ [35841] DSCEngine::depositCollateralAndMintDSC(0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3, 10000000000000000000 [1e19], 24000000000000000000000 [2.4e22])
    │   ├─ emit CollateralDeposited(user: ECRecover: [0x0000000000000000000000000000000000000001], token: 0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3, amount: 10000000000000000000 [1e19])
    │   ├─ [5528] 0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3::transferFrom(ECRecover: [0x0000000000000000000000000000000000000001], DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], 10000000000000000000 [1e19])
    │   │   ├─ emit Approval(owner: ECRecover: [0x0000000000000000000000000000000000000001], spender: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], value: 0)
    │   │   └─ ← [Revert] revert: ERC20: transfer amount exceeds balance
    │   └─ ← [Revert] revert: ERC20: transfer amount exceeds balance
    └─ ← [Revert] Error != expected error: ERC20: transfer amount exceeds balance != DSCEngine__HealthFactorTooLow(500000000000000000 [5e17])

Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 1.33ms (182.38µs CPU time)

Ran 1 test suite in 1.05s (1.33ms CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in test/DSCEngineTest.t.sol:DSCEngineTest
[FAIL: Error != expected error: ERC20: transfer amount exceeds balance != DSCEngine__HealthFactorTooLow(500000000000000000 [5e17])] testRevertsIfMintedDscBreaksHealthFactor() (gas: 117511)

Encountered a total of 1 failing tests, 0 tests succeeded

AFAIU, the test user puts 10 eth collateral, worth $24,000 USD at $2400 price for ETH, then tries to mint all 24000 worth of DSC. It should revert because it should only be able to mint half of that, due to LIQUIDATION_TRESHOLD = 50, but it doesn't...

I'm lost. Am I doing something wrong with the math or health factor calculations? Did I mess up the calculateHealthFactor refactoring?

Answered by EngrPips

Oct 28, 2024

Interesting. If your user is address(1), then why did you mint the token to a different address and not address(1) in your setup as shown in the stack trace below

[24728] ERC20Mock::mint(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], 10000000000000000000 [1e19])
    │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], value: 10000000000000000000 [1e19])
    │   └─ ← [Stop]

View full answer

EngrPips · 2024-10-26T16:52:29Z

EngrPips
Oct 26, 2024

Hello @BowtiedHarpyEagle, Please run forge clean, then delete your cache folder if you have it in your working directory, then run foundryup, then rerun the test and let's see how that will play out.

10 replies

BowtiedHarpyEagle Oct 26, 2024
Author

Same thing, nothing changed.

$ forge clean
$ ls
cache  foundry.toml  lib  README.md  script  src  test
$ rm -rf cache/
$ foundryup


.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx

 ╔═╗ ╔═╗ ╦ ╦ ╔╗╔ ╔╦╗ ╦═╗ ╦ ╦         Portable and modular toolkit
 ╠╣  ║ ║ ║ ║ ║║║  ║║ ╠╦╝ ╚╦╝    for Ethereum Application Development
 ╚   ╚═╝ ╚═╝ ╝╚╝ ═╩╝ ╩╚═  ╩                 written in Rust.

.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx

Repo       : https://github.com/foundry-rs/
Book       : https://book.getfoundry.sh/
Chat       : https://t.me/foundry_rs/
Support    : https://t.me/foundry_support/
Contribute : https://github.com/orgs/foundry-rs/projects/2/

.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx

foundryup: installing foundry (version nightly, tag nightly)
foundryup: downloading latest forge, cast, anvil, and chisel
############################################################################################################ 100.0%
foundryup: downloading manpages
############################################################################################################ 100.0%
foundryup: installed - forge 0.2.0 (192a5a2 2024-10-26T00:22:40.192959901Z)
foundryup: installed - cast 0.2.0 (192a5a2 2024-10-26T00:22:40.232213745Z)
foundryup: installed - anvil 0.2.0 (192a5a2 2024-10-26T00:22:40.153818777Z)
foundryup: installed - chisel 0.2.0 (192a5a2 2024-10-26T00:22:40.110408561Z)
foundryup: done!
$ forge test --mt testRevertsIfMintedDscBreaksHealthFactor -vvvv
[⠊] Compiling...
[⠑] Compiling 39 files with Solc 0.8.26
[⠘] Solc 0.8.26 finished in 1.62s
Compiler run successful!

Ran 1 test for test/DSCEngineTest.t.sol:DSCEngineTest
[FAIL: Error != expected error: ERC20: transfer amount exceeds balance != DSCEngine__HealthFactorTooLow(500000000000000000 [5e17])] testRevertsIfMintedDscBreaksHealthFactor() (gas: 117511)
Logs:
  User WETH balance: 10000000000000000000
  Amount collateral: 10000000000000000000
  Amount to mint: 24000000000000000000000
  Expected health factor: 500000000000000000

Traces:
  [10497440] DSCEngineTest::setUp()
    ├─ [4702604] → new DeployDSC@0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f
    │   └─ ← [Return] 23375 bytes of code
    ├─ [5589325] DeployDSC::run()
    │   ├─ [3731080] → new HelperConfig@0x104fBc016F4bb334D775a19E8A6510109AC63E00
    │   │   ├─ [0] VM::startBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   ├─ [372255] → new MockV3Aggregator@0x34A1D3fff3958843C43aD80F30b94c510645C316
    │   │   │   └─ ← [Return] 1082 bytes of code
    │   │   ├─ [372255] → new MockV3Aggregator@0x90193C961A926261B756D1E5bb255e67ff9498A1
    │   │   │   └─ ← [Return] 1082 bytes of code
    │   │   ├─ [658858] → new ERC20Mock@0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496
    │   │   │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: DeployDSC: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f], value: 100000000000 [1e11])
    │   │   │   └─ ← [Return] 2829 bytes of code
    │   │   ├─ [658858] → new ERC20Mock@0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3
    │   │   │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: DeployDSC: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f], value: 100000000000 [1e11])
    │   │   │   └─ ← [Return] 2829 bytes of code
    │   │   ├─ [0] VM::stopBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   └─ ← [Return] 6894 bytes of code
    │   ├─ [934] HelperConfig::activeNetworkConfig() [staticcall]
    │   │   └─ ← [Return] MockV3Aggregator: [0x34A1D3fff3958843C43aD80F30b94c510645C316], MockV3Aggregator: [0x90193C961A926261B756D1E5bb255e67ff9498A1], ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], ERC20Mock: [0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3], 77814517325470205911140941194401928579557062014761831930645393041380819009408 [7.781e76]
    │   ├─ [0] VM::startBroadcast(<pk>)
    │   │   └─ ← [Return] 
    │   ├─ [741806] → new DecentralizedStableCoin@0x5FbDB2315678afecb367f032d93F642f64180aa3
    │   │   ├─ emit OwnershipTransferred(previousOwner: 0x0000000000000000000000000000000000000000, newOwner: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266)
    │   │   └─ ← [Return] 3361 bytes of code
    │   ├─ [875671] → new DSCEngine@0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512
    │   │   └─ ← [Return] 3696 bytes of code
    │   ├─ [2446] DecentralizedStableCoin::transferOwnership(DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512])
    │   │   ├─ emit OwnershipTransferred(previousOwner: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266, newOwner: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512])
    │   │   └─ ← [Stop] 
    │   ├─ [0] VM::stopBroadcast()
    │   │   └─ ← [Return] 
    │   └─ ← [Return] DecentralizedStableCoin: [0x5FbDB2315678afecb367f032d93F642f64180aa3], DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], HelperConfig: [0x104fBc016F4bb334D775a19E8A6510109AC63E00]
    ├─ [934] HelperConfig::activeNetworkConfig() [staticcall]
    │   └─ ← [Return] MockV3Aggregator: [0x34A1D3fff3958843C43aD80F30b94c510645C316], MockV3Aggregator: [0x90193C961A926261B756D1E5bb255e67ff9498A1], ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], ERC20Mock: [0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3], 77814517325470205911140941194401928579557062014761831930645393041380819009408 [7.781e76]
    ├─ [24728] ERC20Mock::mint(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], 10000000000000000000 [1e19])
    │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], value: 10000000000000000000 [1e19])
    │   └─ ← [Stop] 
    └─ ← [Stop] 

  [117511] DSCEngineTest::testRevertsIfMintedDscBreaksHealthFactor()
    ├─ [8993] MockV3Aggregator::latestRoundData() [staticcall]
    │   └─ ← [Return] 1, 240000000000 [2.4e11], 1, 1, 1
    ├─ [270] DSCEngine::getPrecision() [staticcall]
    │   └─ ← [Return] 1000000000000000000 [1e18]
    ├─ [248] DSCEngine::getAdditionalFeedPrecision() [staticcall]
    │   └─ ← [Return] 10000000000 [1e10]
    ├─ [0] VM::startPrank(ECRecover: [0x0000000000000000000000000000000000000001])
    │   └─ ← [Return] 
    ├─ [24651] ERC20Mock::approve(DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], 10000000000000000000 [1e19])
    │   ├─ emit Approval(owner: ECRecover: [0x0000000000000000000000000000000000000001], spender: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], value: 10000000000000000000 [1e19])
    │   └─ ← [Return] true
    ├─ [4596] DSCEngine::getUsdValue(ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], 10000000000000000000 [1e19]) [staticcall]
    │   ├─ [993] MockV3Aggregator::latestRoundData() [staticcall]
    │   │   └─ ← [Return] 1, 240000000000 [2.4e11], 1, 1, 1
    │   └─ ← [Return] 24000000000000000000000 [2.4e22]
    ├─ [719] DSCEngine::calculateHealthFactor(24000000000000000000000 [2.4e22], 24000000000000000000000 [2.4e22]) [staticcall]
    │   └─ ← [Return] 500000000000000000 [5e17]
    ├─ [2607] ERC20Mock::balanceOf(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D]) [staticcall]
    │   └─ ← [Return] 10000000000000000000 [1e19]
    ├─ [0] console::log("User WETH balance:", 10000000000000000000 [1e19]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] console::log("Amount collateral:", 10000000000000000000 [1e19]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] console::log("Amount to mint:", 24000000000000000000000 [2.4e22]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] console::log("Expected health factor:", 500000000000000000 [5e17]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] VM::expectRevert(custom error 0xf28dceb3: 00000000000000000000000000000000…00000000000000000000000000000000 (128 bytes))
    │   └─ ← [Return] 
    ├─ [35841] DSCEngine::depositCollateralAndMintDSC(ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], 10000000000000000000 [1e19], 24000000000000000000000 [2.4e22])
    │   ├─ emit CollateralDeposited(user: ECRecover: [0x0000000000000000000000000000000000000001], token: ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], amount: 10000000000000000000 [1e19])
    │   ├─ [5528] ERC20Mock::transferFrom(ECRecover: [0x0000000000000000000000000000000000000001], DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], 10000000000000000000 [1e19])
    │   │   ├─ emit Approval(owner: ECRecover: [0x0000000000000000000000000000000000000001], spender: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], value: 0)
    │   │   └─ ← [Revert] revert: ERC20: transfer amount exceeds balance
    │   └─ ← [Revert] revert: ERC20: transfer amount exceeds balance
    └─ ← [Revert] Error != expected error: ERC20: transfer amount exceeds balance != DSCEngine__HealthFactorTooLow(500000000000000000 [5e17])

Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 1.64ms (234.15µs CPU time)

Ran 1 test suite in 1.04s (1.64ms CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in test/DSCEngineTest.t.sol:DSCEngineTest
[FAIL: Error != expected error: ERC20: transfer amount exceeds balance != DSCEngine__HealthFactorTooLow(500000000000000000 [5e17])] testRevertsIfMintedDscBreaksHealthFactor() (gas: 117511)

Encountered a total of 1 failing tests, 0 tests succeeded
$

EngrPips Oct 26, 2024

Hello @BowtiedHarpyEagle, Can you console.log the user address inside of your testRevertsIfMintedDscBreaksHealthFactor because I am unsure why when you prank user the test is showing that it is pranking address(1) as shown in the below stack process that I extract from the stack trace of your testRevertsIfMintedDscBreaksHealthFactor test

 ├─ [0] VM::startPrank(ECRecover: [0x0000000000000000000000000000000000000001])
    │   └─ ← [Return]

Is the user address 0x0000000000000000000000000000000000000001?

BowtiedHarpyEagle Oct 28, 2024
Author

Hello @BowtiedHarpyEagle, Can you console.log the user address inside of your testRevertsIfMintedDscBreaksHealthFactor because I am unsure why when you prank user the test is showing that it is pranking address(1) as shown in the below stack process that I extract from the stack trace of your testRevertsIfMintedDscBreaksHealthFactor test
 ├─ [0] VM::startPrank(ECRecover: [0x0000000000000000000000000000000000000001])
    │   └─ ← [Return] 
Is the user address 0x0000000000000000000000000000000000000001?

OK, I did console.log the user address, and yes, it is address(1). And it shows that way because user is defined that way up in the DSCEngineTest.t.sol, as

address public user = address(1);

so that is expected from the code.

And I got that from the course repo at:
https://github.com/Cyfrin/foundry-defi-stablecoin-cu/blob/main/test/unit/DSCEngineTest.t.sol

Here is the new trace:

$ forge test --mt testRevertsIfMintedDscBreaksHealthFactor -vvvv
[⠊] Compiling...
[⠑] Compiling 1 files with Solc 0.8.26
[⠃] Solc 0.8.26 finished in 1.63s
Compiler run successful!

Ran 1 test for test/DSCEngineTest.t.sol:DSCEngineTest
[FAIL: Error != expected error: ERC20: transfer amount exceeds balance != DSCEngine__HealthFactorTooLow(500000000000000000 [5e17])] testRevertsIfMintedDscBreaksHealthFactor() (gas: 118378)
Logs:
  User address: 0x0000000000000000000000000000000000000001
  User WETH balance: 10000000000000000000
  Amount collateral: 10000000000000000000
  Amount to mint: 24000000000000000000000
  Expected health factor: 500000000000000000

Traces:
  [10497440] DSCEngineTest::setUp()
    ├─ [4702604] → new DeployDSC@0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f
    │   └─ ← [Return] 23375 bytes of code
    ├─ [5589325] DeployDSC::run()
    │   ├─ [3731080] → new HelperConfig@0x104fBc016F4bb334D775a19E8A6510109AC63E00
    │   │   ├─ [0] VM::startBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   ├─ [372255] → new MockV3Aggregator@0x34A1D3fff3958843C43aD80F30b94c510645C316
    │   │   │   └─ ← [Return] 1082 bytes of code
    │   │   ├─ [372255] → new MockV3Aggregator@0x90193C961A926261B756D1E5bb255e67ff9498A1
    │   │   │   └─ ← [Return] 1082 bytes of code
    │   │   ├─ [658858] → new ERC20Mock@0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496
    │   │   │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: DeployDSC: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f], value: 100000000000 [1e11])
    │   │   │   └─ ← [Return] 2829 bytes of code
    │   │   ├─ [658858] → new ERC20Mock@0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3
    │   │   │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: DeployDSC: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f], value: 100000000000 [1e11])
    │   │   │   └─ ← [Return] 2829 bytes of code
    │   │   ├─ [0] VM::stopBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   └─ ← [Return] 6894 bytes of code
    │   ├─ [934] HelperConfig::activeNetworkConfig() [staticcall]
    │   │   └─ ← [Return] MockV3Aggregator: [0x34A1D3fff3958843C43aD80F30b94c510645C316], MockV3Aggregator: [0x90193C961A926261B756D1E5bb255e67ff9498A1], ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], ERC20Mock: [0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3], 77814517325470205911140941194401928579557062014761831930645393041380819009408 [7.781e76]
    │   ├─ [0] VM::startBroadcast(<pk>)
    │   │   └─ ← [Return] 
    │   ├─ [741806] → new DecentralizedStableCoin@0x5FbDB2315678afecb367f032d93F642f64180aa3
    │   │   ├─ emit OwnershipTransferred(previousOwner: 0x0000000000000000000000000000000000000000, newOwner: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266)
    │   │   └─ ← [Return] 3361 bytes of code
    │   ├─ [875671] → new DSCEngine@0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512
    │   │   └─ ← [Return] 3696 bytes of code
    │   ├─ [2446] DecentralizedStableCoin::transferOwnership(DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512])
    │   │   ├─ emit OwnershipTransferred(previousOwner: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266, newOwner: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512])
    │   │   └─ ← [Stop] 
    │   ├─ [0] VM::stopBroadcast()
    │   │   └─ ← [Return] 
    │   └─ ← [Return] DecentralizedStableCoin: [0x5FbDB2315678afecb367f032d93F642f64180aa3], DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], HelperConfig: [0x104fBc016F4bb334D775a19E8A6510109AC63E00]
    ├─ [934] HelperConfig::activeNetworkConfig() [staticcall]
    │   └─ ← [Return] MockV3Aggregator: [0x34A1D3fff3958843C43aD80F30b94c510645C316], MockV3Aggregator: [0x90193C961A926261B756D1E5bb255e67ff9498A1], ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], ERC20Mock: [0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3], 77814517325470205911140941194401928579557062014761831930645393041380819009408 [7.781e76]
    ├─ [24728] ERC20Mock::mint(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], 10000000000000000000 [1e19])
    │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], value: 10000000000000000000 [1e19])
    │   └─ ← [Stop] 
    └─ ← [Stop] 

  [118378] DSCEngineTest::testRevertsIfMintedDscBreaksHealthFactor()
    ├─ [8993] MockV3Aggregator::latestRoundData() [staticcall]
    │   └─ ← [Return] 1, 240000000000 [2.4e11], 1, 1, 1
    ├─ [270] DSCEngine::getPrecision() [staticcall]
    │   └─ ← [Return] 1000000000000000000 [1e18]
    ├─ [248] DSCEngine::getAdditionalFeedPrecision() [staticcall]
    │   └─ ← [Return] 10000000000 [1e10]
    ├─ [0] VM::startPrank(ECRecover: [0x0000000000000000000000000000000000000001])
    │   └─ ← [Return] 
    ├─ [24651] ERC20Mock::approve(DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], 10000000000000000000 [1e19])
    │   ├─ emit Approval(owner: ECRecover: [0x0000000000000000000000000000000000000001], spender: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], value: 10000000000000000000 [1e19])
    │   └─ ← [Return] true
    ├─ [4596] DSCEngine::getUsdValue(ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], 10000000000000000000 [1e19]) [staticcall]
    │   ├─ [993] MockV3Aggregator::latestRoundData() [staticcall]
    │   │   └─ ← [Return] 1, 240000000000 [2.4e11], 1, 1, 1
    │   └─ ← [Return] 24000000000000000000000 [2.4e22]
    ├─ [719] DSCEngine::calculateHealthFactor(24000000000000000000000 [2.4e22], 24000000000000000000000 [2.4e22]) [staticcall]
    │   └─ ← [Return] 500000000000000000 [5e17]
    ├─ [0] console::log("User address:", ECRecover: [0x0000000000000000000000000000000000000001]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [2607] ERC20Mock::balanceOf(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D]) [staticcall]
    │   └─ ← [Return] 10000000000000000000 [1e19]
    ├─ [0] console::log("User WETH balance:", 10000000000000000000 [1e19]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] console::log("Amount collateral:", 10000000000000000000 [1e19]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] console::log("Amount to mint:", 24000000000000000000000 [2.4e22]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] console::log("Expected health factor:", 500000000000000000 [5e17]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] VM::expectRevert(custom error 0xf28dceb3: 00000000000000000000000000000000…00000000000000000000000000000000 (128 bytes))
    │   └─ ← [Return] 
    ├─ [35841] DSCEngine::depositCollateralAndMintDSC(ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], 10000000000000000000 [1e19], 24000000000000000000000 [2.4e22])
    │   ├─ emit CollateralDeposited(user: ECRecover: [0x0000000000000000000000000000000000000001], token: ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], amount: 10000000000000000000 [1e19])
    │   ├─ [5528] ERC20Mock::transferFrom(ECRecover: [0x0000000000000000000000000000000000000001], DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], 10000000000000000000 [1e19])
    │   │   ├─ emit Approval(owner: ECRecover: [0x0000000000000000000000000000000000000001], spender: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], value: 0)
    │   │   └─ ← [Revert] revert: ERC20: transfer amount exceeds balance
    │   └─ ← [Revert] revert: ERC20: transfer amount exceeds balance
    └─ ← [Revert] Error != expected error: ERC20: transfer amount exceeds balance != DSCEngine__HealthFactorTooLow(500000000000000000 [5e17])

Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 13.74ms (1.66ms CPU time)

Ran 1 test suite in 858.99ms (13.74ms CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in test/DSCEngineTest.t.sol:DSCEngineTest
[FAIL: Error != expected error: ERC20: transfer amount exceeds balance != DSCEngine__HealthFactorTooLow(500000000000000000 [5e17])] testRevertsIfMintedDscBreaksHealthFactor() (gas: 118378)

Encountered a total of 1 failing tests, 0 tests succeeded

EngrPips Oct 28, 2024

Interesting. If your user is address(1), then why did you mint the token to a different address and not address(1) in your setup as shown in the stack trace below

[24728] ERC20Mock::mint(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], 10000000000000000000 [1e19])
    │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], value: 10000000000000000000 [1e19])
    │   └─ ← [Stop]

Answer selected by BowtiedHarpyEagle

BowtiedHarpyEagle Oct 28, 2024
Author

Interesting. If your user is address(1), then why did you mint the token to a different address and not address(1) in your setup as shown in the stack trace below

[24728] ERC20Mock::mint(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], 10000000000000000000 [1e19])
    │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], value: 10000000000000000000 [1e19])
    │   └─ ← [Stop]

Because USER was defined differently in the videos up till the point I started copy-pasting from the github repo! lol

Now I have two users, USER and user... ;)

In the setup I added a line to deal money to the user as well.

    function setUp() public {
        deployer = new DeployDSC();
        (dsc, dscengine, config) = deployer.run();
        (ethUsdPriceFeed, btcUsdPriceFeed, weth,,) = config.activeNetworkConfig();
        ERC20Mock(weth).mint(USER, STARTING_ERC20_BALANCE);
        ERC20Mock(weth).mint(user, STARTING_ERC20_BALANCE);
    }

also corrected the user balance in the console logs:

       console.log("User address:", user);
        console.log("User WETH balance:", ERC20Mock(weth).balanceOf(user));
        console.log("Amount collateral:", amountCollateral);
        console.log("Amount to mint:", amountToMint);
        console.log("Expected health factor:", expectedHealthFactor);

Now when I run the test, it still fails, but in a different way. Now there is money in the account, so the transfer passes. But it doesn't revert while it should.

New trace:

$ forge test --mt testRevertsIfMintedDscBreaksHealthFactor -vvvv
[⠊] Compiling...
No files changed, compilation skipped

Ran 1 test for test/unit/DSCEngineTest.t.sol:DSCEngineTest
[FAIL: next call did not revert as expected] testRevertsIfMintedDscBreaksHealthFactor() (gas: 246284)
Logs:
  User address: 0x0000000000000000000000000000000000000001
  User WETH balance: 10000000000000000000
  Amount collateral: 10000000000000000000
  Amount to mint: 24000000000000000000000
  Expected health factor: 500000000000000000

Traces:
  [10524821] DSCEngineTest::setUp()
    ├─ [4702604] → new DeployDSC@0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f
    │   └─ ← [Return] 23375 bytes of code
    ├─ [5589325] DeployDSC::run()
    │   ├─ [3731080] → new HelperConfig@0x104fBc016F4bb334D775a19E8A6510109AC63E00
    │   │   ├─ [0] VM::startBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   ├─ [372255] → new MockV3Aggregator@0x34A1D3fff3958843C43aD80F30b94c510645C316
    │   │   │   └─ ← [Return] 1082 bytes of code
    │   │   ├─ [372255] → new MockV3Aggregator@0x90193C961A926261B756D1E5bb255e67ff9498A1
    │   │   │   └─ ← [Return] 1082 bytes of code
    │   │   ├─ [658858] → new ERC20Mock@0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496
    │   │   │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: DeployDSC: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f], value: 100000000000 [1e11])
    │   │   │   └─ ← [Return] 2829 bytes of code
    │   │   ├─ [658858] → new ERC20Mock@0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3
    │   │   │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: DeployDSC: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f], value: 100000000000 [1e11])
    │   │   │   └─ ← [Return] 2829 bytes of code
    │   │   ├─ [0] VM::stopBroadcast()
    │   │   │   └─ ← [Return] 
    │   │   └─ ← [Return] 6894 bytes of code
    │   ├─ [934] HelperConfig::activeNetworkConfig() [staticcall]
    │   │   └─ ← [Return] MockV3Aggregator: [0x34A1D3fff3958843C43aD80F30b94c510645C316], MockV3Aggregator: [0x90193C961A926261B756D1E5bb255e67ff9498A1], ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], ERC20Mock: [0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3], 77814517325470205911140941194401928579557062014761831930645393041380819009408 [7.781e76]
    │   ├─ [0] VM::startBroadcast(<pk>)
    │   │   └─ ← [Return] 
    │   ├─ [741806] → new DecentralizedStableCoin@0x5FbDB2315678afecb367f032d93F642f64180aa3
    │   │   ├─ emit OwnershipTransferred(previousOwner: 0x0000000000000000000000000000000000000000, newOwner: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266)
    │   │   └─ ← [Return] 3361 bytes of code
    │   ├─ [875671] → new DSCEngine@0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512
    │   │   └─ ← [Return] 3696 bytes of code
    │   ├─ [2446] DecentralizedStableCoin::transferOwnership(DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512])
    │   │   ├─ emit OwnershipTransferred(previousOwner: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266, newOwner: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512])
    │   │   └─ ← [Stop] 
    │   ├─ [0] VM::stopBroadcast()
    │   │   └─ ← [Return] 
    │   └─ ← [Return] DecentralizedStableCoin: [0x5FbDB2315678afecb367f032d93F642f64180aa3], DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], HelperConfig: [0x104fBc016F4bb334D775a19E8A6510109AC63E00]
    ├─ [934] HelperConfig::activeNetworkConfig() [staticcall]
    │   └─ ← [Return] MockV3Aggregator: [0x34A1D3fff3958843C43aD80F30b94c510645C316], MockV3Aggregator: [0x90193C961A926261B756D1E5bb255e67ff9498A1], ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], ERC20Mock: [0xBb2180ebd78ce97360503434eD37fcf4a1Df61c3], 77814517325470205911140941194401928579557062014761831930645393041380819009408 [7.781e76]
    ├─ [24728] ERC20Mock::mint(user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], 10000000000000000000 [1e19])
    │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: user: [0x6CA6d1e2D5347Bfab1d91e883F1915560e09129D], value: 10000000000000000000 [1e19])
    │   └─ ← [Stop] 
    ├─ [24728] ERC20Mock::mint(ECRecover: [0x0000000000000000000000000000000000000001], 10000000000000000000 [1e19])
    │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: ECRecover: [0x0000000000000000000000000000000000000001], value: 10000000000000000000 [1e19])
    │   └─ ← [Stop] 
    └─ ← [Stop] 

  [246284] DSCEngineTest::testRevertsIfMintedDscBreaksHealthFactor()
    ├─ [8993] MockV3Aggregator::latestRoundData() [staticcall]
    │   └─ ← [Return] 1, 240000000000 [2.4e11], 1, 1, 1
    ├─ [270] DSCEngine::getPrecision() [staticcall]
    │   └─ ← [Return] 1000000000000000000 [1e18]
    ├─ [248] DSCEngine::getAdditionalFeedPrecision() [staticcall]
    │   └─ ← [Return] 10000000000 [1e10]
    ├─ [0] VM::startPrank(ECRecover: [0x0000000000000000000000000000000000000001])
    │   └─ ← [Return] 
    ├─ [24651] ERC20Mock::approve(DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], 10000000000000000000 [1e19])
    │   ├─ emit Approval(owner: ECRecover: [0x0000000000000000000000000000000000000001], spender: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], value: 10000000000000000000 [1e19])
    │   └─ ← [Return] true
    ├─ [4596] DSCEngine::getUsdValue(ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], 10000000000000000000 [1e19]) [staticcall]
    │   ├─ [993] MockV3Aggregator::latestRoundData() [staticcall]
    │   │   └─ ← [Return] 1, 240000000000 [2.4e11], 1, 1, 1
    │   └─ ← [Return] 24000000000000000000000 [2.4e22]
    ├─ [719] DSCEngine::calculateHealthFactor(24000000000000000000000 [2.4e22], 24000000000000000000000 [2.4e22]) [staticcall]
    │   └─ ← [Return] 500000000000000000 [5e17]
    ├─ [0] console::log("User address:", ECRecover: [0x0000000000000000000000000000000000000001]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [2607] ERC20Mock::balanceOf(ECRecover: [0x0000000000000000000000000000000000000001]) [staticcall]
    │   └─ ← [Return] 10000000000000000000 [1e19]
    ├─ [0] console::log("User WETH balance:", 10000000000000000000 [1e19]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] console::log("Amount collateral:", 10000000000000000000 [1e19]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] console::log("Amount to mint:", 24000000000000000000000 [2.4e22]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] console::log("Expected health factor:", 500000000000000000 [5e17]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [0] VM::expectRevert(custom error 0xf28dceb3: 00000000000000000000000000000000…00000000000000000000000000000000 (128 bytes))
    │   └─ ← [Return] 
    ├─ [165756] DSCEngine::depositCollateralAndMintDSC(ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], 10000000000000000000 [1e19], 24000000000000000000000 [2.4e22])
    │   ├─ emit CollateralDeposited(user: ECRecover: [0x0000000000000000000000000000000000000001], token: ERC20Mock: [0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496], amount: 10000000000000000000 [1e19])
    │   ├─ [30493] ERC20Mock::transferFrom(ECRecover: [0x0000000000000000000000000000000000000001], DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], 10000000000000000000 [1e19])
    │   │   ├─ emit Approval(owner: ECRecover: [0x0000000000000000000000000000000000000001], spender: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], value: 0)
    │   │   ├─ emit Transfer(from: ECRecover: [0x0000000000000000000000000000000000000001], to: DSCEngine: [0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512], value: 10000000000000000000 [1e19])
    │   │   └─ ← [Return] true
    │   ├─ [993] MockV3Aggregator::latestRoundData() [staticcall]
    │   │   └─ ← [Return] 1, 240000000000 [2.4e11], 1, 1, 1
    │   ├─ [8993] MockV3Aggregator::latestRoundData() [staticcall]
    │   │   └─ ← [Return] 1, 6600000000000 [6.6e12], 1, 1, 1
    │   ├─ [48942] DecentralizedStableCoin::mint(ECRecover: [0x0000000000000000000000000000000000000001], 24000000000000000000000 [2.4e22])
    │   │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: ECRecover: [0x0000000000000000000000000000000000000001], value: 24000000000000000000000 [2.4e22])
    │   │   └─ ← [Return] true
    │   └─ ← [Stop] 
    └─ ← [Revert] next call did not revert as expected

Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 13.28ms (2.35ms CPU time)

Ran 1 test suite in 1.00s (13.28ms CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in test/unit/DSCEngineTest.t.sol:DSCEngineTest
[FAIL: next call did not revert as expected] testRevertsIfMintedDscBreaksHealthFactor() (gas: 246284)

Encountered a total of 1 failing tests, 0 tests succeeded

I think there is something wrong with health factor stuff as well.

I'll take a short break...

Rest of my code is here:
https://github.com/BowtiedHarpyEagle/advfoundry-03-defi-stablecoin/tree/c16b8f53f67dab30b9cbfb7bab222a9e684a3146

EngrPips Oct 28, 2024

Take a break and try to figure out why your health factor is not breaking when it is supposed to break. You can do the calculation on paper and see what are the values you are getting vs what values you are expecting. Me checking through the codebase and telling you the error without you trying won't help you much. Just to point out that we fixed the main issue you opened this discussion for and this is another issue. I will be waiting to hear what you find out.

BowtiedHarpyEagle Oct 28, 2024
Author

OK after a good night's sleep and returning back to this issue, I found out the problem. It was the math with the 1e18 precision. Calculated-expected health factor was 5e17, because it was calculated with multiplying by PRECISION (1e18). MIN_HEALTH_FACTOR, otoh was just 1, without the e18, so the calculated health factor was larger than 1, MIN_HEALTH_FACTOR, so it didn't revert. Changing the MIN_HEALTH_FACTOR to 1e18 solved the remaining issue.

Those tests are among the most challenging parts of the course for me.

EngrPips Oct 28, 2024

Indeed this section is a pretty advanced one and if you understand everything that is taught in the section you have a good foundation already.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Advanced Foundry, Section 3 DeFi-StableCoin, Lesson 19 testRevertsIfMintedDscBreaksHealthFactor fails with the wrong error #2750

{{title}}

Replies: 1 comment 10 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

Select a reply

Advanced Foundry, Section 3 DeFi-StableCoin, Lesson 19 testRevertsIfMintedDscBreaksHealthFactor fails with the wrong error #2750

BowtiedHarpyEagle Oct 26, 2024

Replies: 1 comment · 10 replies

EngrPips Oct 26, 2024

BowtiedHarpyEagle Oct 26, 2024 Author

EngrPips Oct 26, 2024

BowtiedHarpyEagle Oct 28, 2024 Author

EngrPips Oct 28, 2024

BowtiedHarpyEagle Oct 28, 2024 Author

EngrPips Oct 28, 2024

BowtiedHarpyEagle Oct 28, 2024 Author

EngrPips Oct 28, 2024

BowtiedHarpyEagle
Oct 26, 2024

Replies: 1 comment 10 replies

EngrPips
Oct 26, 2024

BowtiedHarpyEagle Oct 26, 2024
Author

BowtiedHarpyEagle Oct 28, 2024
Author

BowtiedHarpyEagle Oct 28, 2024
Author

BowtiedHarpyEagle Oct 28, 2024
Author