FundMe not working properly

[ustisa]

Hi, I tried everything in order to be able to fund my contract with 5-6 Ether but it is not working and not working, I tried to paste the exact codes from the section but still it reverts, I tried to make the constructor payable and it was the only thing that was able to work out, do you have any ideas what might be wrong? Those are the 2 codes:
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.18;

import {AggregatorV3Interface} from "@chainlink/contracts@1.2.0/src/v0.8/shared/interfaces/AggregatorV3Interface.sol";

library PriceConverter {
// We could make this public, but then we'd have to deploy it
function getPrice() internal view returns (uint256) {
// Sepolia ETH / USD Address
// https://docs.chain.link/data-feeds/price-feeds/addresses
AggregatorV3Interface priceFeed = AggregatorV3Interface(
0x694AA1769357215DE4FAC081bf1f309aDC325306
);
(, int256 answer, , , ) = priceFeed.latestRoundData();
// ETH/USD rate in 18 digit
return uint256(answer * 10000000000);
}

// 1000000000
function getConversionRate(
    uint256 ethAmount
) internal view returns (uint256) {
    uint256 ethPrice = getPrice();
    uint256 ethAmountInUsd = (ethPrice * ethAmount) / 1000000000000000000;
    // the actual ETH/USD conversion rate, after adjusting the extra 0s.
    return ethAmountInUsd;
}

}
And this one:
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.18;

import {AggregatorV3Interface} from "@chainlink/contracts@1.2.0/src/v0.8/shared/interfaces/AggregatorV3Interface.sol";

import "./PriceConverter.sol";

// constant, immutable

error NotOwner();
contract FundMe{
using PriceConverter for uint256;

address[] public funders;
mapping (address funder => uint256 amountFunded) public addressToAmountFunded;

address public immutable i_owner;
uint256 public constant MINIMUM_USD = 5 * 10 ** 18;
// 2552 gas
// 439 gas

constructor() payable {
    i_owner = msg.sender;
}

function fund() public payable{
    msg.value.getConversionRate();
     require(msg.value.getConversionRate() >= MINIMUM_USD,"Did not send enough ETH");
    addressToAmountFunded[msg.sender] += msg.value;
    funders.push(msg.sender);
}

// //  function fund() public payable {
//     require(msg.value.getConversionRate() >= MINIMUM_USD, "You need to spend more ETH!");
//     // require(PriceConverter.getConversionRate(msg.value) >= MINIMUM_USD, "You need to spend more ETH!");
//     addressToAmountFunded[msg.sender] += msg.value;
//     funders.push(msg.sender);
function getVersion() public view returns (uint256) {
    AggregatorV3Interface priceFeed = AggregatorV3Interface(0x694AA1769357215DE4FAC081bf1f309aDC325306);
    return priceFeed.version();
}

function withdraw() public onlyOwner{
    // SINGLE = - SET
    // DOUBLE == - IS 
    // for(/* starting index, ending index, step amount */)
    for(uint256 funderIndex =0; funderIndex < funders.length; funderIndex++){
      address funder = funders[funderIndex];
      addressToAmountFunded[funder] = 0;
    }
    funders = new address[](0);
    (bool callSuccess, ) = payable(msg.sender).call{value: address(this).balance}("");
    require(callSuccess, "Call failed");
    // payable(msg.sender).transfer(address(this).balance);
}

modifier onlyOwner() {
    // require(msg.sender == owner);
    if (msg.sender != i_owner) revert NotOwner();
    _;
}

receive() external payable { 
    fund();
}

fallback() external payable { 
    fund();
}

}

[EngrPips]

Hello @ustisa, Please run your code with the -vvvvv flag and show the stack trace of the process.

[ustisa]

Hey there, I’m working in Remix. Could you clarify how to use the -vvvvv flag or point me to where I can use it?

[EngrPips]

If you are working on Remix, that is a different story altogether. On what chain are you running your process?

[ustisa]

Remix VM (cancun)

[ustisa]

Used Remix VM - Sepolia fork and it worked!

[ustisa]

Thanks for the help!

[chainflash]

I reviewed your code and it seems correct. With this information I can't guess what your issue might be. send a picture that shows the details.
Try clearing the Remix history from your browser and then test again.
If everything is correct it should work.

[ustisa]

Could it be because I am not using the injected provider metamask but instead Remix VM (cancun)?

[ustisa]

[ustisa]

Used Remix VM - Sepolia fork and it worked!

[ustisa]

Thanks for the help!

[KMean]

@ustisa If you're using remix remove the version from your imports

import {AggregatorV3Interface} from "@chainlink/contracts@1.2.0/src/v0.8/shared/interfaces/AggregatorV3Interface.sol"

to

import {AggregatorV3Interface} from "@chainlink/contracts/src/v0.8/shared/interfaces/AggregatorV3Interface.sol"

what are you trying to do here in the constructor?

msg.value.getConversionRate(); // Does nothing

dont make you constructor payable, you dont need it here!
We are hard coding the datafeed for sepolia here, so make sure to inject your wallet and use sepolia (11155111)

AggregatorV3Interface priceFeed = AggregatorV3Interface(0x694AA1769357215DE4FAC081bf1f309aDC325306);

once you have deployed on sepolia try to call the fund function sending this value ( 0.005 ETH):

5000000000000000

your code reviewed

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.18;

import {AggregatorV3Interface} from "@chainlink/contracts/src/v0.8/shared/interfaces/AggregatorV3Interface.sol";

import {PriceConverter} from "./PriceConverter.sol"; //<-- named import please

// constant, immutable

error NotOwner();
contract FundMe{
    using PriceConverter for uint256;

    address[] public funders;
    mapping (address funder => uint256 amountFunded) public addressToAmountFunded;

    address public immutable i_owner;
    uint256 public constant MINIMUM_USD = 5 * 10 ** 18;
    // 2552 gas
    // 439 gas

    constructor() {
        i_owner = msg.sender;
    }

    function fund() public payable{
        require(msg.value.getConversionRate() >= MINIMUM_USD,"Did not send enough ETH");
        addressToAmountFunded[msg.sender] += msg.value;
        funders.push(msg.sender);
    }

    // //  function fund() public payable {
    //     require(msg.value.getConversionRate() >= MINIMUM_USD, "You need to spend more ETH!");
    //     // require(PriceConverter.getConversionRate(msg.value) >= MINIMUM_USD, "You need to spend more ETH!");
    //     addressToAmountFunded[msg.sender] += msg.value;
    //     funders.push(msg.sender);
    function getVersion() public view returns (uint256) {
        AggregatorV3Interface priceFeed = AggregatorV3Interface(0x694AA1769357215DE4FAC081bf1f309aDC325306);
        return priceFeed.version();
    }

    function withdraw() public onlyOwner{
        // SINGLE = - SET
        // DOUBLE == - IS 
        // for(/* starting index, ending index, step amount */)
        for(uint256 funderIndex =0; funderIndex < funders.length; funderIndex++){
        address funder = funders[funderIndex];
        addressToAmountFunded[funder] = 0;
        }
        funders = new address[](0);
        (bool callSuccess, ) = payable(msg.sender).call{value: address(this).balance}("");
        require(callSuccess, "Call failed");
        // payable(msg.sender).transfer(address(this).balance);
    }

    modifier onlyOwner() {
        // require(msg.sender == owner);
        if (msg.sender != i_owner) revert NotOwner();
        _;
    }

    receive() external payable { 
        fund();
    }

    fallback() external payable { 
        fund();
    }
}

[ustisa]

With Remix VM - Sepolia Fork it worked! With the Metamask injected provider it did not because I was out of any sepolia ethers,
Thank you so much!

[ustisa]

But very interesting when it is Remix VM - Cancun, it shows error and reverts

[KMean]

because we are hard coding the datafeed which works only on sepolia.

[ustisa]

Man, thank you so much, I really appreciate the help!

[KMean]

Man, thank you so much, I really appreciate the help!

my pleasure.

[chainflash]

awesome

[EngrPips]

great heads-up.