Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally update existing model with equations to AMR #31

Closed
brandomr opened this issue Aug 30, 2023 · 3 comments
Closed

Optionally update existing model with equations to AMR #31

brandomr opened this issue Aug 30, 2023 · 3 comments

Comments

@brandomr
Copy link
Contributor

Per @YohannParis there is a need to use /equations_to_amr to re-run equations for an existing model. To support this, the endpoint should optionally take model_id. If provided, the resulting AMR would update the model in place instead of creating a new one.

@YohannParis
Copy link
Member

It's not entirely accurate, but still right.
On the HMI we create an empty model (with an id, name, and description) before letting the user open it and entering equations, therefore we need to update this "empty" but already existing model.

@brandomr
Copy link
Contributor Author

@YohannParis got it--so there won't be existing metadata that needs to be brought over. It's just updating the empty shell with something real

@YohannParis
Copy link
Member

@YohannParis got it--so there won't be existing metadata that needs to be brought over. It's just updating the empty shell with something real

You are right! Just an id, name, description will be present.

@brandomr brandomr closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants