Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly incorrect type hinting in PyCIEMSS optimization interface #41

Closed
liunelson opened this issue Aug 29, 2023 · 1 comment
Closed
Assignees

Comments

@liunelson
Copy link
Member

In pyciemss/PetriNetODE/interfaces.py, the type hints for the functions load_and_optimize_and_sample_petri_model and load_and_calibrate_and_optimize_and_sample_petri_model appear to be incorrect.

The arguments initial_guess and bounds both have type hints Iterable[float] and default values 0.5 and [[0.0], [1.0]] respectively. Based on the context and examples, they may need to be replaced with

  • initial_guess: Iterable[float] = [0.5]
  • bounds: Iterable[Iterable[float]] = [[0.0], [1.0]]

Unrelated: load_and_calibrate_and_optimize_and_sample_petri_model has the argument deterministic_learnable_parameters but it is missing from the docstring. Please fix this so one can read about what this argument does.

@anirban-chaudhuri
Copy link

We have resolved these issues in the pyciemss repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants