Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttles: Make emergency stop default when no heartbeat comes in even if it has not been requested by the throttle #420

Open
habazut opened this issue Aug 26, 2024 · 1 comment
Labels
Enhancement New feature or request

Comments

@habazut
Copy link
Contributor

habazut commented Aug 26, 2024

Investigate how heartbeat is implemented and do stop any active loco unless the throttle does say it does NOT want that.

Heatbeat incoming               Active Loco(s)             Emergency stop requested by throttle             What we do
yes                                                                                                                                                    all fine
no                                         no                                 unknown or yes or no                                     does not matter
no                                         yes                                do stop                                                           stop all
no                                         yes                                no stop                                                           no stop
no                                         yes                                unknown                                                        stop all

Think this trough for Withrottle and DCCEX protocols.

@habazut habazut added the Enhancement New feature or request label Aug 26, 2024
@Asbelos
Copy link
Contributor

Asbelos commented Aug 26, 2024

Beware complex scenarios with locos handed off, or being run by other throttles when throttle is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants