Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a cell without change doesn't alter save status #116

Merged
merged 2 commits into from
Jul 12, 2024
Merged

fix: a cell without change doesn't alter save status #116

merged 2 commits into from
Jul 12, 2024

Conversation

kunfang98927
Copy link
Contributor

Resolves: #115

@kunfang98927 kunfang98927 requested a review from yinanazhou July 12, 2024 02:42
yinanazhou
yinanazhou requested changes Jul 12, 2024
View reviewed changes
Copy link
Member

@yinanazhou yinanazhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to set variables for oldValue and newValue for better readability

@kunfang98927 kunfang98927 merged commit ec3761c into main Jul 12, 2024
2 checks passed
@kunfang98927 kunfang98927 deleted the saved-status-fix branch July 12, 2024 17:13
kunfang98927 added a commit that referenced this pull request Jul 12, 2024
@kunfang98927
feat: optimize MEI validate && add new empty file
7129062 
1. **Optimization:**
  - Optimized MEI validation (PR #121)

2. **Fixes:**
  - Prevented text content from being stored as an image (PR #120)
  - Removed MEI row in `meiData` when cleared (PR #118)
  - Ensured a cell without change doesn't alter save status (PR #116)
  - Displayed empty table when header is invalid (PR #114)

3. **Features:**
  - Added support for new empty files (PR #112)

Refs: PR #121, #120, #118, #116, #114, #112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinanazhou yinanazhou yinanazhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If a cell is clicked but nothing is changed, saved status should not change to not saved
2 participants
@kunfang98927 @yinanazhou