-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mei encoding - precedes / follows issue #1130
Open
timothydereuse
wants to merge
7
commits into
develop
Choose a base branch
from
fix-MEIprecedesfollows
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothydereuse
changed the title
Fix me iprecedesfollows
Fix mei encoding - precedes / follows issue
Feb 9, 2024
Also made changes for #1122 |
@homework36 could you please follow up this PR? |
yinanazhou
force-pushed
the
fix-MEIprecedesfollows
branch
from
December 4, 2024 16:30
bb6a6df
to
565b568
Compare
yinanazhou
force-pushed
the
fix-MEIprecedesfollows
branch
from
December 4, 2024 16:46
2990a4c
to
52d6b80
Compare
The CI test cannot pass.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1112
Makes a few changes to ensure that two custodes cannot appear in the same syllable (and does a little improvement to the local testing script to aid in debugging this issue).
The whole build_mei_file.py file is still a little long and unwieldy and should be broken up, but that should be fixed in its own PR.