From b275f6890c089617c132e6690064395a5202164c Mon Sep 17 00:00:00 2001 From: Dylan Hillerbrand Date: Thu, 5 Oct 2023 07:51:29 -0400 Subject: [PATCH] Format code --- .../management/commands/import_instruments.py | 2 +- .../management/commands/import_languages.py | 4 +- .../instruments/migrations/0001_initial.py | 196 ++++++++++++++---- .../VIM/apps/instruments/models/instrument.py | 10 +- 4 files changed, 171 insertions(+), 41 deletions(-) diff --git a/web-app/django/VIM/apps/instruments/management/commands/import_instruments.py b/web-app/django/VIM/apps/instruments/management/commands/import_instruments.py index bc477b1..a0a32d6 100644 --- a/web-app/django/VIM/apps/instruments/management/commands/import_instruments.py +++ b/web-app/django/VIM/apps/instruments/management/commands/import_instruments.py @@ -86,7 +86,7 @@ def get_instrument_data(self, instrument_ids: list[str]) -> list[dict]: def create_database_objects(self, instrument_attrs: dict, ins_img_url: str) -> None: """ - Given a dictionary of instrument attributes and a url to an instrument image, + Given a dictionary of instrument attributes and a url to an instrument image, create the corresponding database objects. instrument_attrs [dict]: Dictionary of instrument attributes. See diff --git a/web-app/django/VIM/apps/instruments/management/commands/import_languages.py b/web-app/django/VIM/apps/instruments/management/commands/import_languages.py index f22ee35..da9d52d 100644 --- a/web-app/django/VIM/apps/instruments/management/commands/import_languages.py +++ b/web-app/django/VIM/apps/instruments/management/commands/import_languages.py @@ -6,10 +6,10 @@ class Command(BaseCommand): """ The import_languages command populates the database with languages in which instrument names can be provided in VIM. - + NOTE: For now, this script only imports English and French. """ - + help = "Imports possible languages for instrument names from Wikidata." def handle(self, *args, **options): diff --git a/web-app/django/VIM/apps/instruments/migrations/0001_initial.py b/web-app/django/VIM/apps/instruments/migrations/0001_initial.py index d2932b5..54f5491 100644 --- a/web-app/django/VIM/apps/instruments/migrations/0001_initial.py +++ b/web-app/django/VIM/apps/instruments/migrations/0001_initial.py @@ -5,64 +5,188 @@ class Migration(migrations.Migration): - initial = True - dependencies = [ - ] + dependencies = [] operations = [ migrations.CreateModel( - name='AVResource', + name="AVResource", fields=[ - ('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')), - ('type', models.CharField(choices=[('audio', 'Audio'), ('video', 'Video'), ('image', 'Image')], help_text='What type of audiovisual resource is this?', max_length=5)), - ('format', models.CharField()), - ('url', models.URLField(max_length=1000)), - ('instrument_date', models.DateField(blank=True, help_text='When was this instrument made?', null=True)), - ('instrument_maker', models.CharField(blank=True, help_text='Who made this instrument?')), - ('instrument_description', models.TextField(blank=True, help_text='Additional information about the instrument.')), - ('source_name', models.CharField(help_text='What is the name of the source of this AVResource?')), + ( + "id", + models.BigAutoField( + auto_created=True, + primary_key=True, + serialize=False, + verbose_name="ID", + ), + ), + ( + "type", + models.CharField( + choices=[ + ("audio", "Audio"), + ("video", "Video"), + ("image", "Image"), + ], + help_text="What type of audiovisual resource is this?", + max_length=5, + ), + ), + ("format", models.CharField()), + ("url", models.URLField(max_length=1000)), + ( + "instrument_date", + models.DateField( + blank=True, + help_text="When was this instrument made?", + null=True, + ), + ), + ( + "instrument_maker", + models.CharField(blank=True, help_text="Who made this instrument?"), + ), + ( + "instrument_description", + models.TextField( + blank=True, + help_text="Additional information about the instrument.", + ), + ), + ( + "source_name", + models.CharField( + help_text="What is the name of the source of this AVResource?" + ), + ), ], ), migrations.CreateModel( - name='Instrument', + name="Instrument", fields=[ - ('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')), - ('wikidata_id', models.CharField(max_length=20, unique=True)), - ('hornbostel_sachs_class', models.CharField(blank=True, help_text='Hornbostel-Sachs classification', max_length=50)), - ('mimo_class', models.CharField(blank=True, help_text='Musical Instrument Museums Online classification', max_length=50)), - ('default_image', models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.PROTECT, related_name='default_image_of', to='instruments.avresource')), + ( + "id", + models.BigAutoField( + auto_created=True, + primary_key=True, + serialize=False, + verbose_name="ID", + ), + ), + ("wikidata_id", models.CharField(max_length=20, unique=True)), + ( + "hornbostel_sachs_class", + models.CharField( + blank=True, + help_text="Hornbostel-Sachs classification", + max_length=50, + ), + ), + ( + "mimo_class", + models.CharField( + blank=True, + help_text="Musical Instrument Museums Online classification", + max_length=50, + ), + ), + ( + "default_image", + models.ForeignKey( + blank=True, + null=True, + on_delete=django.db.models.deletion.PROTECT, + related_name="default_image_of", + to="instruments.avresource", + ), + ), ], ), migrations.CreateModel( - name='Language', + name="Language", fields=[ - ('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')), - ('wikidata_code', models.CharField(help_text='Language code in Wikidata', unique=True)), - ('wikidata_id', models.CharField(help_text='Language ID (Q number) in Wikidata', unique=True)), - ('en_label', models.CharField(help_text='Language label in English')), - ('autonym', models.CharField(help_text='Language label in the language itself')), + ( + "id", + models.BigAutoField( + auto_created=True, + primary_key=True, + serialize=False, + verbose_name="ID", + ), + ), + ( + "wikidata_code", + models.CharField( + help_text="Language code in Wikidata", unique=True + ), + ), + ( + "wikidata_id", + models.CharField( + help_text="Language ID (Q number) in Wikidata", unique=True + ), + ), + ("en_label", models.CharField(help_text="Language label in English")), + ( + "autonym", + models.CharField(help_text="Language label in the language itself"), + ), ], ), migrations.CreateModel( - name='InstrumentName', + name="InstrumentName", fields=[ - ('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')), - ('name', models.CharField(max_length=50)), - ('source_name', models.CharField(help_text='Who or what called the instrument this?', max_length=50)), - ('instrument', models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to='instruments.instrument')), - ('language', models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to='instruments.language')), + ( + "id", + models.BigAutoField( + auto_created=True, + primary_key=True, + serialize=False, + verbose_name="ID", + ), + ), + ("name", models.CharField(max_length=50)), + ( + "source_name", + models.CharField( + help_text="Who or what called the instrument this?", + max_length=50, + ), + ), + ( + "instrument", + models.ForeignKey( + on_delete=django.db.models.deletion.PROTECT, + to="instruments.instrument", + ), + ), + ( + "language", + models.ForeignKey( + on_delete=django.db.models.deletion.PROTECT, + to="instruments.language", + ), + ), ], ), migrations.AddField( - model_name='avresource', - name='instrument', - field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to='instruments.instrument'), + model_name="avresource", + name="instrument", + field=models.ForeignKey( + on_delete=django.db.models.deletion.PROTECT, to="instruments.instrument" + ), ), migrations.AddField( - model_name='avresource', - name='instrument_description_language', - field=models.ForeignKey(blank=True, help_text='What language is Instrument Description written in?', null=True, on_delete=django.db.models.deletion.PROTECT, to='instruments.language'), + model_name="avresource", + name="instrument_description_language", + field=models.ForeignKey( + blank=True, + help_text="What language is Instrument Description written in?", + null=True, + on_delete=django.db.models.deletion.PROTECT, + to="instruments.language", + ), ), ] diff --git a/web-app/django/VIM/apps/instruments/models/instrument.py b/web-app/django/VIM/apps/instruments/models/instrument.py index 26d42e5..f7a6d3b 100644 --- a/web-app/django/VIM/apps/instruments/models/instrument.py +++ b/web-app/django/VIM/apps/instruments/models/instrument.py @@ -10,5 +10,11 @@ class Instrument(models.Model): null=True, related_name="default_image_of", ) - hornbostel_sachs_class = models.CharField(max_length=50, blank=True, help_text = "Hornbostel-Sachs classification") - mimo_class = models.CharField(max_length=50, blank=True, help_text = "Musical Instrument Museums Online classification") + hornbostel_sachs_class = models.CharField( + max_length=50, blank=True, help_text="Hornbostel-Sachs classification" + ) + mimo_class = models.CharField( + max_length=50, + blank=True, + help_text="Musical Instrument Museums Online classification", + )