Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] LSTM and SAC - Am I understanding the docs correctly? #1924

Closed
4 tasks done
DJT777 opened this issue May 10, 2024 · 3 comments
Closed
4 tasks done

[Question] LSTM and SAC - Am I understanding the docs correctly? #1924

DJT777 opened this issue May 10, 2024 · 3 comments
Labels
duplicate This issue or pull request already exists question Further information is requested

Comments

@DJT777
Copy link

DJT777 commented May 10, 2024

❓ Question

Hello!

I was reading the docs here https://stable-baselines3.readthedocs.io/en/master/modules/sac.html#notes and it notes that it does not accept recurrent policies. If I implement my own custom network into SAC then will it not run if I use an LSTM to encode the observation space before a forward pass to something like a MLP based critic or actor?

Basically just wondering if any use of an LSTM at all in a custom policy network would be supported or not. The docs are indicating that it's not, and I want to make sure: https://stable-baselines3.readthedocs.io/en/master/modules/sac.html#notes

image

Is that saying the SAC implementation won't support ANY recurrent neural networks or it doesn't support the available recurrent policies developed and available in the library.

Checklist

@DJT777 DJT777 added the question Further information is requested label May 10, 2024
@araffin araffin added the duplicate This issue or pull request already exists label May 10, 2024
@DJT777
Copy link
Author

DJT777 commented May 10, 2024

@araffin If the question is duplicate can you point me in the direction to the discussion about implementation of LSTM into SAC?

@araffin
Copy link
Member

araffin commented May 10, 2024

Related to Stable-Baselines-Team/stable-baselines3-contrib#201 and Stable-Baselines-Team/stable-baselines3-contrib#222 (and maybe other I forgot)

Basically just wondering if any use of an LSTM at all in a custom policy network would be supported or not.

No lstm at all is supported currently, you would need to fork SB3 too (see related issues to have a starting point).

@DJT777
Copy link
Author

DJT777 commented May 10, 2024

@araffin awesome, thank you!

@DJT777 DJT777 closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants