Feature/3854 separate on hold

[richard-jones]

• Issue: https://github.com/DOAJ/doajPM/issues/3854

---

Add On Hold filter to dashboard

On Hold items are separated from regular applications in the dashboard, and can be filtered separately.

This PR...

• has scripts to run
• has migrations to run
• adds new infrastructure
• changes the CI pipeline
• affects the public site
• affects the editorial area
• affects the publisher area
• affects the monitoring

Developer Checklist

Developers should review and confirm each of these items before requesting review

• Code meets acceptance criteria from issue
• Unit tests are written and all pass
• User Test Scripts (if required) are written and have been run through
• Project's coding standards are met
  • No deprecated methods are used
  • No magic strings/numbers - all strings are in constants or messages files
  • ES queries are wrapped in a Query object rather than inlined in the code
  • Where possible our common library functions have been used (e.g. dates manipulated via dates)
  • Cleaned up commented out code, etc
  • Urls are constructed with url_for not hard-coded
• Code documentation and related non-code documentation has all been updated
  • Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
  • Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
• Migation has been created and tested
• There is a recent merge from develop

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer

• Code meets acceptance criteria from issue
• Unit tests are written and all pass
• User Test Scripts (if required) are written and have been run through
• Project's coding standards are met
  • No deprecated methods are used
  • No magic strings/numbers - all strings are in constants or messages files
  • ES queries are wrapped in a Query object rather than inlined in the code
  • Where possible our common library functions have been used (e.g. dates manipulated via dates)
  • Cleaned up commented out code, etc
  • Urls are constructed with url_for not hard-coded
• Code documentation and related non-code documentation has all been updated
  • Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
  • Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
• Migation has been created and tested
• There is a recent merge from develop

Testing

List user test scripts that need to be run

Main feature test:

• https://doaj.github.io/doaj-docs/feature/3854_separate_on_hold/testbook/index.html#dashboard/maned_todo_list
• https://doaj.github.io/doaj-docs/feature/3854_separate_on_hold/testbook/index.html#dashboard/editorial_group_status

Regression testing to ensure no side-effects:

• https://doaj.github.io/doaj-docs/feature/3854_separate_on_hold/testbook/index.html#dashboard/editor_todo_list
• https://doaj.github.io/doaj-docs/feature/3854_separate_on_hold/testbook/index.html#dashboard/associate_editor_todo_list
• https://doaj.github.io/doaj-docs/feature/3854_separate_on_hold/testbook/index.html#dashboard/editorial_group_status_for_editors

Deployment

N/A

[philipkcl]

minor questions

[philipkcl]

auto test seem still working after comment those save,
do we sill need those save function calls?