Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate water quality data from USGS #21

Open
thodson-usgs opened this issue Nov 17, 2020 · 1 comment
Open

validate water quality data from USGS #21

thodson-usgs opened this issue Nov 17, 2020 · 1 comment

Comments

@thodson-usgs
Copy link
Collaborator

Water quality data may have invalid values, which can be problematic when they occur in datetime fields. Change default query behavior to return only valid data.
thodson-usgs pushed a commit that referenced this issue Nov 14, 2022
@cjbas22 @sblack-usu
@Nouri1992 @Nouri-1992
Fixing get_pmcodes, making multi-level indexing optional, and adding …
7164878 
…missing data to get_qwdata and get_gwlevels (#53)

* New get_pmcodes function

This upload fixes issue #17.

* Update nwis.py

* Update nwis.py

* Update waterdata_pmcodes.txt

* This PR fixes issue #18.

* Update waterdata_pmcodes.txt

* fix the metadata test for variable_info

* update tests to mock multiple parameter_cd

* update test_get_info parameter_cd to a list

* This upload fixes issue #20

* Fix issue #21

* This upload fixes issue #22

* Revert "This upload fixes issue #20"

This reverts commit 938c3d5.

* Revert 66b8b7c, acd1a54, 938c3d5

* Making multi-level indexing optional

This modification addresses issue #25  by adding an additional parameter multi_index to some functions. When multi_index=False the output will be a dataframe with a single-level index (datetime) independently of the number of sites being queried.

* Update nwis.py

* Returning all raw data from get_qwdata and get_gwleveles

This addresses issue #27 by modifying the function that parses date and time from get_qwdata and get_gwleveles avoiding data loss.

Co-authored-by: Scott Black <sblack@cuahsi.org>
Co-authored-by: Nouri1992 <46764664+Nouri1992@users.noreply.github.com>
Co-authored-by: Nouri1992 <nour.atallah@usu.edu>
@lstanish-usgs
Copy link
Collaborator

@thodson-usgs checking in on this old issue, is this for WQP data, NWIS data, or both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thodson-usgs @lstanish-usgs