Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs workflow test #198

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Docs workflow test #198

merged 4 commits into from
Sep 7, 2023

Conversation

chkim-usgs
Copy link
Contributor

Pushes to s3://asc-public-docs

@acpaquette
Copy link
Collaborator

acpaquette commented Sep 6, 2023

@chkim-usgs Python 3.6 and 3.7 are no longer supported. Can we updated the python versions in the CI python version matrix to [3.8, 3.9, 3.10, 3.11]?

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Sep 7, 2023

Can we get the readme updated with instructions to build the docs. Currently I am getting:

Theme error:
An error happened in rendering the page developers/index.
Reason: UndefinedError("'style' is undefined")

trying to build locally. Maybe a missing dep?

@chkim-usgs
Copy link
Contributor Author

@Kelvinrr If you create a conda environment with the docs yaml environment_docs.yaml, the docs should build properly. I can update the environment.yml to support docs build and the readme as well.

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Sep 7, 2023

@chkim-usgs That did it thanks, must have missed that file. It looks good, there are some weird formatting things but I think those probably existed before and most likely not your problem to solve.

Screenshot 2023-09-07 at 11 10 46 AM

One thing worth adding as it's related to the footers. Is some CSS along the lines of

.bodywrapper {
    min-height: 100vh;
}

Which is an easy way to force the footer to the bottom one smaller pages on the site. There is some stuff in the custom.css to do this but the docs setup here is a little weird. You can probably add it to the already existing CSS. That + the readme update and I think this is good to go.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@98206cc). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage        ?   53.38%           
=======================================
  Files           ?       35           
  Lines           ?     2377           
  Branches        ?        0           
=======================================
  Hits            ?     1269           
  Misses          ?     1108           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

Create the `plio` conda environment:

```
conda env create -f environment.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, premature approve, this needs to be environment_docs.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually updated the environment.yml file to support docs build (just added sphinx dep), should I revert that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it enough to completely build the docs? Pretty sure you need all the docs deps to build it not just sphinx-build command. I manually installed sphinx earlier and ended up with that error from before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hm, I tested it out by creating a new conda env with the updated yaml file and ran the sphinx-build command without issue. Also, I did have to pin the sphinx version to 6.2.1 so if you did a casual conda install sphinx, it may have installed a version (7.0+) that is known to cause the error you ran into.

Copy link
Collaborator

@Kelvinrr Kelvinrr Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that seemed to be the issue. I assumed there was other stuff needed for the themes and such and I guess in my rampant context switching I missed that this has the theme locally.

@Kelvinrr Kelvinrr merged commit f2414a2 into main Sep 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants