Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EagleIO poller creating dup messages #68

Open
dajtxx opened this issue Apr 30, 2024 · 1 comment
Open

EagleIO poller creating dup messages #68

dajtxx opened this issue Apr 30, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dajtxx
Copy link
Collaborator

dajtxx commented Apr 30, 2024

The EagleIO poller is using a message hash to try and avoid dup messages but it doesn't seem to be working.

See logical device 283 for example. Some data points are being recorded many times, with a timestamp from 2022.

Perhaps the hash calculation is using too much info so something is changing the hash when the data points themselves are not changing.

I now see some of the values are changing, eg salinity & temperature are not getting value-specific timestamps, but these ones that are not changing such as battV, adc ch3, etc keep getting added to the message even though their timestamps and values are not changing.

That explains why the hash keeps changing, and it would do so even if only calculated using the timeseries array.

We should talk about this and see whether those old values can or should be filtered out.

@dajtxx dajtxx added the bug Something isn't working label Apr 30, 2024
@dajtxx dajtxx added enhancement New feature or request and removed bug Something isn't working labels May 6, 2024
@bsefton12
Copy link
Member

It's possible this was due to Fisheries recently removing a C4E due to failure. The node was still transmitting battery etc so the poller was updating and transmitting the old salinity/temperature values. Not 100% sure this is the issue so I'll leave this open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants