Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Create Table command in AppStack.ts not idempotent. #1033

Open
alantao912 opened this issue Oct 18, 2023 · 3 comments
Open

[BUG]: Create Table command in AppStack.ts not idempotent. #1033

alantao912 opened this issue Oct 18, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@alantao912
Copy link
Contributor

Operating system

Windows 11

Bug description

Create Table command in AppStack.ts throws an exception if the specified table already exists in DynamoDB. Prevents SST from starting. In other words, the command is not idempotent. We should check if the table exists first, and if not, create it then.

Steps to reproduce

Un-comment the

const trainspaceRunTable = new Table(...); 

lines of code, and then type dlp-cli start.

It should complain about the specified table already existing, and then fail to start.

@alantao912 alantao912 added the bug Something isn't working label Oct 18, 2023
@github-actions
Copy link
Contributor

Hello @alantao912! Thank you for submitting the 🐞Bug Request Form. We appreciate your contribution. 👋

We will look into it and provide a response as soon as possible.

To work on this bug request, you can follow these branch setup instructions:

  1. Checkout the main branch:
```
 git checkout nextjs
```
  1. Pull the latest changes from the remote main branch:
```
 git pull origin nextjs
```
  1. Create a new branch specific to this bug request using the issue number:
    git checkout -b bug-1033

Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

Best regards,
Deep Learning Playground (DLP) Team

@karkir0003
Copy link
Member

@alantao912 status on this?

@karkir0003
Copy link
Member

@alantao912 any status on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants