Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dev Velocity for Terraform #1127

Open
karkir0003 opened this issue Feb 5, 2024 · 3 comments
Open

Improve Dev Velocity for Terraform #1127

karkir0003 opened this issue Feb 5, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@karkir0003
Copy link
Member

Currently, when we write AWS infra using terraform, we have to run a set of manual commands to setup terraform along with validating + applying the tf plans. We should try to experiment with integrating these commands into dlp-cli. Below are some use cases we should add to the dlp-cli:

Deliverables

  1. @MugPand , what instructions/steps did you follow to setup terraform?
    a. Implement a dlp-cli command to setup terraform for our use for DLP. We keep all terraform files in dlp-terraform/ directory
  2. Implement a dlp-cli command to be able to validate terraform schemas across all .tf files in the dlp-terraform directory. We validate .tf files using terraform validate
  3. Implement a dlp-cli command to be able to apply a .tf file by creating the resources in AWS. Eg: something like dlp-cli terraform apply dynamodb/ should run terraform apply within the dlp-terraform/dynamodb path for dynamodb.tf file
  4. Modify our github actions checks to ensure that for a given .tf file, it's under a folder within dlp-terraform (like check valid folder schema within dlp-terraform directory
@karkir0003 karkir0003 added the good first issue Good for newcomers label Feb 5, 2024
@noah-iversen
Copy link
Contributor

@michellewliang if you don't have Terraform already, here's the instructions: https://developer.hashicorp.com/terraform/tutorials/aws-get-started/install-cli

@noah-iversen
Copy link
Contributor

Adding @abhinavish to this as well. You guys can split up the deliverables however you like.

I can foresee these all being separate PRs.

@noah-iversen
Copy link
Contributor

For now, I think @michellewliang can do 1 and 2, and @abhinavish can do 3 and 4.

@MugPand MugPand assigned MugPand and unassigned michellewliang and abhinavish May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: In Progress
Development

No branches or pull requests

5 participants