Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

Zoom in more when search #145

Closed
a-thansen opened this issue Nov 24, 2023 · 8 comments · Fixed by #182
Closed

Zoom in more when search #145

a-thansen opened this issue Nov 24, 2023 · 8 comments · Fixed by #182
Assignees
Labels
feature New feature or request frontend Frontend related Inspect map Features related to the inspect map page Main map Features related to the main map page

Comments

@a-thansen
Copy link
Contributor

No description provided.

@zoi23333 zoi23333 self-assigned this Nov 27, 2023
@Seb-sti1
Copy link
Contributor

in order to do that one'll need to get the result of the searched (somewhere in the main.tsx) and use the coordinates of the road to figure out how much to zoom. Then refactor ForceMapUpdate component to take a zoom parameter in argument

@Seb-sti1 Seb-sti1 added this to the Release 4 (final) milestone Nov 27, 2023
@marcosantiagomuro
Copy link
Contributor

I think we should force a bigger zoom also when we inspect a road / road branch

@marcosantiagomuro
Copy link
Contributor

if I select this one

image

then it shows only like this

image

when maybe would be better to show it this size?

image

@zoi23333
Copy link
Contributor

if I select this one

image then it shows only like this image when maybe would be better to show it this size? image

Yea, make sense, i'll try to do together with the main page one

@marcosantiagomuro
Copy link
Contributor

although that is Seb's branch, just realised so first maybe we need to merge it

@zoi23333
Copy link
Contributor

Also, I see this issue was moved to Release 4, do we need to have it fixed before this Friday for presentation?

@zoi23333
Copy link
Contributor

zoi23333 commented Dec 5, 2023

My another report spending the time over my expectation, so haven't got time to check this issue. but I'll check it before this Thursday afternoon

@zoi23333
Copy link
Contributor

zoi23333 commented Dec 7, 2023

Now, Set a temporary fixed parameter for zoom In and calculated the distance between the two farthest nodes in a path.

To do:

  • Make ZoomIn parameter and Distance parameter related

  • Organize my spaghetti code

@Seb-sti1 Seb-sti1 added feature New feature or request frontend Frontend related Main map Features related to the main map page Inspect map Features related to the inspect map page labels Dec 15, 2023
@Seb-sti1 Seb-sti1 linked a pull request Dec 17, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request frontend Frontend related Inspect map Features related to the inspect map page Main map Features related to the main map page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants