Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HIP to be used with NVIDIA GPUs #169

Open
davebayer opened this issue Mar 14, 2024 · 1 comment
Open

Allow HIP to be used with NVIDIA GPUs #169

davebayer opened this issue Mar 14, 2024 · 1 comment

Comments

@davebayer
Copy link

Currently when HIP as the library backend, vendor and other parameters are set to AMD. We can use __HIP_PLATFORM_AMD__ and __HIP_PLATFORM_NVIDIA__ macros to detect what is the target device to set up everything properly.

@DTolm
Copy link
Owner

DTolm commented Mar 22, 2024

Hello,

Sorry for the long reply, I am busy with another project at this moment. I can add subflags for HIP version of Nvidia (if anyone even uses it), however, the solution you provided in the pull request is not correct. All the parameters in the backend-specific parts were specifically tuned for the particular backend, which is why they are not unified.

Best regards,
Dmitrii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants