Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

known macOS fixes to pull #16

Closed
illwieckz opened this issue Feb 21, 2021 · 6 comments
Closed

known macOS fixes to pull #16

illwieckz opened this issue Feb 21, 2021 · 6 comments

Comments

@illwieckz
Copy link
Member

illwieckz commented Feb 21, 2021

I noticed there are some macOS-related fixes in that fork: https://github.com/xuewuli/crunch

Those fixes are mixed with other related features so some manpower is required to extract the fixes we may want before merging them.

Currently, the crn lib (the part integrated in the engine) is known to build on macOS, but the crunch tool is known to not build yet, so we may be interested in some of these fixes.

I open that issue to not forget about those fixes and their availability.

@illwieckz
Copy link
Member Author

illwieckz commented Feb 21, 2021

The commit message explicitly talks about iOS so maybe there are some non-x86 fixes as well there.

@illwieckz
Copy link
Member Author

illwieckz commented Jul 28, 2022

@illwieckz
Copy link
Member Author

illwieckz commented Jul 28, 2022

The fixes from Unity-Technologies#15 by @blaztinn look easier to review as the one in https://github.com/xuewuli/crunch by @xuewuli as it is like a jumbo commit, so we may start with Unity-Technologies#15 and then look at https://github.com/xuewuli/crunch to see if there are extra stuff to cherry-pick.

@illwieckz
Copy link
Member Author

@ArctypeZach would you be able to merge Unity-Technologies#15 on top of our tree on your side and,

  1. test it on mac to check if it works on your side, if possible on M1 too,
  2. and eventually review the code?

@ArctypeZach
Copy link

Yup - can do over the weekend

@illwieckz
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants