Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another fix for an issue affecting the encoder on macOS #28

Closed
illwieckz opened this issue Jul 28, 2022 · 1 comment
Closed

Another fix for an issue affecting the encoder on macOS #28

illwieckz opened this issue Jul 28, 2022 · 1 comment

Comments

@illwieckz
Copy link
Member

illwieckz commented Jul 28, 2022 •
edited
Loading

See:

The commit 4bb735f7966eedf414aa8e24533967cffd5bbcdb only fixed the threading limit on the decoder part. Use the limit also in the encoder.

Without this change we got random black squares on converted textures when compressed on Macos with 24 threads.

The issue was not reproducible on Windows but I've added the limit there also in case it is a race issue that is harder to trigger on Windows.

@ArctypeZach you may also be interested in testing that so we can merge it.
@illwieckz
Copy link
Member Author

Done:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@illwieckz