Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could dependency on onnxruntime be avoided? #91

Open
wtholliday opened this issue Jan 29, 2024 · 1 comment
Open

could dependency on onnxruntime be avoided? #91

wtholliday opened this issue Jan 29, 2024 · 1 comment

Comments

@wtholliday
Copy link

I'm working on a port of NeuralNote to visionOS and hitting some trouble getting onnxruntime to compile for visionOS.

Comment here says that Features is doing a CQT (what does "harmonically stack" mean?). I was wondering if other CQT code could be used instead of the onnx model? For example: https://github.com/cannam/constant-q-cpp

@DamRsn
Copy link
Owner

DamRsn commented Feb 7, 2024

Hi,

Yes the ONNXRuntime dependency could be avoided, but getting the CQT working exactly the same in another framework/in pure C++ might be a bit of work.

Concerning this library, I don't know if we could get exactly the same thing, but with a few tweaks probably yes.

Harmonic stacking is kind of a reshape operation of the CQT array so that bins with frequency being a multiple of the same fundamental frequency stacks on a new dimension. You can look on the BasicPitch repo here to see how it's implemented.

If you manage to get the features working without ONNXRuntime, please let me know, I'd be pretty happy to integrate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants