From bd96e09513158bbc00954d2bd2ff1eba8dfa0481 Mon Sep 17 00:00:00 2001 From: Aaron Leventhal Date: Tue, 26 Apr 2022 19:15:16 -0700 Subject: [PATCH] Avoid adding nested pseudo elements twice in a11y tree Some nested pseudo elements can get added twice in the tree, when their layout parent and DOM parent lead to different AXObjects that can both add them. A good solution will pass both of these tests: All/DumpAccessibilityTreeTest.AccessibilityCSSFirstLetter/blink external/wpt/accessibility/crashtests/bdo-table-cell.html This code will go away once legacy layout is completely removed. See discussion in CL. Bug: 1314808 Change-Id: I6a993cd3981719240737a79be79afd3b65ca42b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3591572 Reviewed-by: Rune Lillesveen Auto-Submit: Aaron Leventhal Reviewed-by: Daniel Libby Reviewed-by: Mason Freed Commit-Queue: Aaron Leventhal Cr-Commit-Position: refs/heads/main@{#996484} --- accessibility/crashtests/bdo-table-cell.html | 21 ++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 accessibility/crashtests/bdo-table-cell.html diff --git a/accessibility/crashtests/bdo-table-cell.html b/accessibility/crashtests/bdo-table-cell.html new file mode 100644 index 00000000000000..ae12541f8d8cb9 --- /dev/null +++ b/accessibility/crashtests/bdo-table-cell.html @@ -0,0 +1,21 @@ + + + + + x + + + + + +