Skip to content

Commit

Permalink
[process-agent] explicitly invoke the tagger component to fix contain…
Browse files Browse the repository at this point in the history
…er tagging (#23001)

[process-agent] explicitly invoke the tagger component to fix container tagging
  • Loading branch information
wiyu authored Feb 21, 2024
1 parent 9379574 commit 36b0bfd
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
3 changes: 3 additions & 0 deletions cmd/process-agent/command/main_common.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ func runApp(ctx context.Context, globalParams *GlobalParams) error {
profiler.Component,
expvars.Component,
apiserver.Component,
// TODO: This is needed by the container-provider which is not currently a component.
// We should ensure the tagger is a dependency when converting to a component.
tagger.Component,
) {
}),

Expand Down
12 changes: 8 additions & 4 deletions cmd/process-agent/subcommands/check/check.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,14 @@ type dependencies struct {

CliParams *cliParams

Config config.Component
Syscfg sysprobeconfig.Component
Log log.Component
Hostinfo hostinfo.Component
Config config.Component
Syscfg sysprobeconfig.Component
Log log.Component
Hostinfo hostinfo.Component
// TODO: the tagger is used by the ContainerProvider, which is currently not a component so there is no direct
// dependency on it. The ContainerProvider needs to be componentized so it can be injected and have fx manage its
// lifecycle.
Tagger tagger.Component
WorkloadMeta workloadmeta.Component
Checks []types.CheckComponent `group:"check"`
}
Expand Down

0 comments on commit 36b0bfd

Please sign in to comment.