[clusteragent/autoscaling] Pass correct value of internal spec to hash

[jennchenn]

What does this PR do?

Update logic to pass the correct value of the internal spec to hashing function before comparing with remote spec.

Motivation

Remote/internal spec was being reported as different even though they both matched. Fixes CASCL-65

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

1. Deploy a cluster with autoscaling enabled
2. Enable autoscaling via the UI
3. Check that cluster is being autoscaled / DatadogPodAutoscaler status updates

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 44462305 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=44462305 --os-family=ubuntu

Note: This applies to commit a4a2c74

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: e50840b9-2c51-407d-95a7-66baa8fea682 Metrics dashboard Target profiles

Baseline: 7c22280
Comparison: 26ac7b1

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	basic_py_check	% cpu utilization	+2.11	[-0.62, +4.85]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.76	[-0.00, +1.53]	1	Logs
➖	file_tree	memory utilization	+0.17	[+0.06, +0.29]	1	Logs
➖	pycheck_lots_of_tags	% cpu utilization	+0.01	[-2.62, +2.64]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.03	[-0.10, +0.03]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.62	[-1.44, +0.20]	1	Logs
➖	idle	memory utilization	-0.62	[-0.67, -0.58]	1	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
❌	idle	memory_usage	9/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[jennchenn]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

[dd-devflow]

❌ MergeQueue: This merge request is not mergeable, blocked by github

PR can't be merged according to github policy

If you need support, contact us on Slack #devflow with those details!

[jennchenn]

/merge

[dd-devflow]

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!