Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clusteragent/autoscaling] Pass correct value of internal spec to hash #29374

Merged
merged 3 commits into from
Sep 16, 2024
Merged

[clusteragent/autoscaling] Pass correct value of internal spec to hash #29374

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b18723f
Pass correct value of internal spec to hash
jennchenn Sep 16, 2024
26ac7b1
Avoid derefencing local spec
jennchenn Sep 16, 2024
a4a2c74
Merge branch 'main' into jenn/cascl-fix-hash-diff-remote
jennchenn Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/clusteragent/autoscaling/workload/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,13 +241,13 @@ func (c *Controller) syncPodAutoscaler(ctx context.Context, key, ns, name string
// and compare it with the one in the PodAutoscaler. If they differ, we should update the PodAutoscaler
// otherwise store the Generation
if podAutoscalerInternal.Generation() != podAutoscaler.Generation {
localHash, err := autoscaling.ObjectHash(podAutoscalerInternal.Spec)
localHash, err := autoscaling.ObjectHash(podAutoscalerInternal.Spec())
if err != nil {
c.store.Unlock(key)
return autoscaling.Requeue, fmt.Errorf("Failed to compute Spec hash for PodAutoscaler: %s/%s, err: %v", ns, name, err)
}

remoteHash, err := autoscaling.ObjectHash(podAutoscaler.Spec)
remoteHash, err := autoscaling.ObjectHash(&podAutoscaler.Spec)
if err != nil {
c.store.Unlock(key)
return autoscaling.Requeue, fmt.Errorf("Failed to compute Spec hash for PodAutoscaler: %s/%s, err: %v", ns, name, err)
Expand Down
Loading