Fix race condition setting global tags in Azure Container Apps. #30743

purple4reina · 2024-11-04T21:04:39Z

What does this PR do?

Addresses a race condition when setting tags for azure container apps profiles.

Motivation

=== RUN   TestSetTraceTagOk
1730756207138578000 [Info] Starting to load the configuration
1730756207139042000 [Warn] config key fleet_policies_dir is unknown
1730756207139820000 [Error] Error when subscribing to remote config management remote configuration is not supported in serverless
1730756207140153000 [Info] Loaded configuration: /does-not-exist.yml
--- PASS: TestSetTraceTagOk (0.02s)
=== RUN   TestOutOfOrderInvocations
1730756207163683000 [Debug] Starting daemon to receive messages from runtime...
==================
WARNING: DATA RACE
Read at 0x00c000167198 by goroutine 140:
  github.com/DataDog/datadog-agent/pkg/trace/api.(*HTTPReceiver).profileProxyHandler()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/trace/api/profiles.go:102 +0x430
  github.com/DataDog/datadog-agent/pkg/trace/api.init.func15()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/trace/api/endpoints.go:99 +0x28
  github.com/DataDog/datadog-agent/pkg/trace/api.(*HTTPReceiver).buildMux()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/trace/api/api.go:203 +0x1f4
  github.com/DataDog/datadog-agent/pkg/trace/api.(*HTTPReceiver).Start()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/trace/api/api.go:255 +0x294
  github.com/DataDog/datadog-agent/pkg/trace/agent.(*Agent).Run()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/trace/agent/agent.go:191 +0x388
  github.com/DataDog/datadog-agent/pkg/serverless/trace.StartServerlessTraceAgent.gowrap1()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/trace/trace.go:119 +0x34

Previous write at 0x00c000167198 by goroutine 104:
  github.com/DataDog/datadog-agent/pkg/trace/agent.(*Agent).SetGlobalTagsUnsafe()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/trace/agent/agent.go:735 +0x60
  github.com/DataDog/datadog-agent/pkg/serverless/trace.(*serverlessTraceAgent).SetTags()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/trace/trace.go:152 +0x28
  github.com/DataDog/datadog-agent/pkg/serverless/daemon.(*Daemon).setTraceTags()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/daemon/daemon.go:442 +0x218
  github.com/DataDog/datadog-agent/pkg/serverless/daemon.TestSetTraceTagOk()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/daemon/daemon_test.go:179 +0x278
  testing.tRunner()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1690 +0x184
  testing.(*T).Run.gowrap1()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1743 +0x40

Goroutine 140 (running) created at:
  github.com/DataDog/datadog-agent/pkg/serverless/trace.StartServerlessTraceAgent()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/trace/trace.go:119 +0x398
  github.com/DataDog/datadog-agent/pkg/serverless/daemon.TestSetTraceTagOk()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/daemon/daemon_test.go:174 +0x1e8
  testing.tRunner()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1690 +0x184
  testing.(*T).Run.gowrap1()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1743 +0x40

Goroutine 104 (finished) created at:
  testing.(*T).Run()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1743 +0x5e0
  testing.runTests.func1()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:2168 +0x80
  testing.tRunner()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1690 +0x184
  testing.runTests()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:2166 +0x6e0
  testing.(*M).Run()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:2034 +0xb74
  github.com/DataDog/datadog-agent/pkg/serverless/daemon.TestMain()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/daemon/daemon_test.go:31 +0x94
  main.main()
      _testmain.go:95 +0x114
==================
==================
WARNING: DATA RACE
Read at 0x00c00040ed20 by goroutine 140:
  runtime.mapassign_fast64ptr()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/runtime/map_fast64.go:214 +0x36c
  github.com/DataDog/datadog-agent/pkg/trace/api.(*HTTPReceiver).profileProxyHandler()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/trace/api/profiles.go:102 +0x44c
  github.com/DataDog/datadog-agent/pkg/trace/api.init.func15()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/trace/api/endpoints.go:99 +0x28
  github.com/DataDog/datadog-agent/pkg/trace/api.(*HTTPReceiver).buildMux()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/trace/api/api.go:203 +0x1f4
  github.com/DataDog/datadog-agent/pkg/trace/api.(*HTTPReceiver).Start()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/trace/api/api.go:255 +0x294
  github.com/DataDog/datadog-agent/pkg/trace/agent.(*Agent).Run()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/trace/agent/agent.go:191 +0x388
  github.com/DataDog/datadog-agent/pkg/serverless/trace.StartServerlessTraceAgent.gowrap1()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/trace/trace.go:119 +0x34

Previous write at 0x00c00040ed20 by goroutine 104:
  runtime.mapaccess2_faststr()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/runtime/map_faststr.go:117 +0x42c
  github.com/DataDog/datadog-agent/pkg/serverless/tags.buildTags()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/tags/tags.go:173 +0x148
  github.com/DataDog/datadog-agent/pkg/serverless/tags.BuildTracerTags()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/tags/tags.go:167 +0x4c
  github.com/DataDog/datadog-agent/pkg/serverless/daemon.(*Daemon).setTraceTags()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/daemon/daemon.go:442 +0x1f8
  github.com/DataDog/datadog-agent/pkg/serverless/daemon.TestSetTraceTagOk()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/daemon/daemon_test.go:179 +0x278
  testing.tRunner()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1690 +0x184
  testing.(*T).Run.gowrap1()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1743 +0x40

Goroutine 140 (running) created at:
  github.com/DataDog/datadog-agent/pkg/serverless/trace.StartServerlessTraceAgent()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/trace/trace.go:119 +0x398
  github.com/DataDog/datadog-agent/pkg/serverless/daemon.TestSetTraceTagOk()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/daemon/daemon_test.go:174 +0x1e8
  testing.tRunner()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1690 +0x184
  testing.(*T).Run.gowrap1()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1743 +0x40

Goroutine 104 (finished) created at:
  testing.(*T).Run()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1743 +0x5e0
  testing.runTests.func1()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:2168 +0x80
  testing.tRunner()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1690 +0x184
  testing.runTests()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:2166 +0x6e0
  testing.(*M).Run()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:2034 +0xb74
  github.com/DataDog/datadog-agent/pkg/serverless/daemon.TestMain()
      /Users/rey.abolofia/go/src/github.com/DataDog/datadog-agent/pkg/serverless/daemon/daemon_test.go:31 +0x94
  main.main()
      _testmain.go:95 +0x114
==================
1730756207164898000 [Debug] Waiting to shut down HTTP server
1730756207165086000 [Debug] Shutting down HTTP server
1730756207165571000 [Debug] Beginning metrics flush at time 1730756207
1730756207165946000 [Debug] Finished metrics flush that was started at time 1730756207
1730756207166192000 [Debug] Beginning logs flush at time 1730756207
1730756207166555000 [Debug] Finished logs flush that was started at time 1730756207
1730756207166881000 [Debug] Beginning traces flush at time 1730756207
1730756207167263000 [Debug] Finished traces flush that was started at time 1730756207
1730756207167403000 [Debug] Finished flushing
1730756207167530000 [Debug] Shutting down agents
1730756207167731000 [Debug] Serverless agent shutdown complete
    testing.go:1399: race detected during execution of test
--- FAIL: TestOutOfOrderInvocations (0.01s)
FAIL
FAIL	github.com/DataDog/datadog-agent/pkg/serverless/daemon	0.377s
FAIL

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

duncanpharvey

LGTM!

Confirmed profile tags are successfully added in Azure Container Apps:

ajgajg1134

looks good from agent-apm!

github-actions · 2024-11-04T21:55:12Z

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between 88a940f and d62e848.

tl;dr

Use these benchmarks as an insight tool during development.

Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.
The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │         sec/op         │    sec/op     vs base               │
api-gateway-appsec.json                            88.77µ ± 3%    92.11µ ± 4%  +3.77% (p=0.035 n=10)
api-gateway-kong-appsec.json                       70.12µ ± 8%    70.46µ ± 3%       ~ (p=0.796 n=10)
api-gateway-kong.json                              68.49µ ± 1%    69.85µ ± 2%       ~ (p=0.052 n=10)
api-gateway-non-proxy-async.json                   108.0µ ± 1%    110.1µ ± 1%  +1.94% (p=0.004 n=10)
api-gateway-non-proxy.json                         108.0µ ± 2%    110.3µ ± 1%  +2.10% (p=0.000 n=10)
api-gateway-websocket-connect.json                 72.53µ ± 2%    73.30µ ± 2%       ~ (p=0.075 n=10)
api-gateway-websocket-default.json                 64.98µ ± 2%    65.56µ ± 2%       ~ (p=0.481 n=10)
api-gateway-websocket-disconnect.json              65.17µ ± 2%    64.86µ ± 1%       ~ (p=0.353 n=10)
api-gateway.json                                   118.8µ ± 1%    118.8µ ± 3%       ~ (p=0.912 n=10)
application-load-balancer.json                     65.51µ ± 1%    65.74µ ± 1%       ~ (p=0.631 n=10)
cloudfront.json                                    49.05µ ± 3%    49.77µ ± 1%       ~ (p=0.105 n=10)
cloudwatch-events.json                             39.83µ ± 2%    39.89µ ± 1%       ~ (p=0.853 n=10)
cloudwatch-logs.json                               67.88µ ± 2%    69.09µ ± 1%  +1.79% (p=0.007 n=10)
custom.json                                        31.95µ ± 3%    32.49µ ± 2%       ~ (p=0.218 n=10)
dynamodb.json                                      96.89µ ± 2%    96.84µ ± 1%       ~ (p=0.436 n=10)
empty.json                                         30.12µ ± 3%    30.73µ ± 2%  +2.01% (p=0.006 n=10)
eventbridge-custom.json                            49.45µ ± 2%    50.29µ ± 1%  +1.69% (p=0.011 n=10)
eventbridge-no-bus.json                            47.90µ ± 2%    47.86µ ± 1%       ~ (p=0.796 n=10)
eventbridge-no-timestamp.json                      47.73µ ± 2%    48.25µ ± 2%       ~ (p=0.165 n=10)
eventbridgesns.json                                65.40µ ± 1%    66.30µ ± 2%  +1.38% (p=0.001 n=10)
eventbridgesqs.json                                74.58µ ± 2%    73.88µ ± 1%       ~ (p=0.280 n=10)
http-api.json                                      75.14µ ± 2%    75.89µ ± 1%  +1.00% (p=0.019 n=10)
kinesis-batch.json                                 73.98µ ± 2%    73.72µ ± 1%       ~ (p=0.739 n=10)
kinesis.json                                       56.10µ ± 1%    56.79µ ± 2%       ~ (p=0.052 n=10)
s3.json                                            62.26µ ± 2%    62.79µ ± 2%       ~ (p=0.218 n=10)
sns-batch.json                                     94.60µ ± 3%    95.88µ ± 2%       ~ (p=0.143 n=10)
sns.json                                           71.05µ ± 2%    72.30µ ± 2%       ~ (p=0.052 n=10)
snssqs.json                                        121.3µ ± 1%    123.6µ ± 2%  +1.93% (p=0.003 n=10)
snssqs_no_dd_context.json                          109.9µ ± 2%    111.4µ ± 2%       ~ (p=0.165 n=10)
sqs-aws-header.json                                62.00µ ± 3%    63.33µ ± 2%       ~ (p=0.123 n=10)
sqs-batch.json                                     99.84µ ± 1%   101.81µ ± 1%  +1.97% (p=0.000 n=10)
sqs.json                                           76.70µ ± 2%    77.67µ ± 3%       ~ (p=0.143 n=10)
sqs_no_dd_context.json                             70.41µ ± 2%    71.39µ ± 2%       ~ (p=0.105 n=10)
stepfunction.json                                  50.82µ ± 4%    50.99µ ± 2%       ~ (p=0.280 n=10)
geomean                                            68.34µ         69.12µ       +1.13%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.34Ki ± 0%   37.27Ki ± 0%  -0.17% (p=0.000 n=10)
api-gateway-kong-appsec.json                      26.93Ki ± 0%   26.94Ki ± 0%       ~ (p=0.669 n=10)
api-gateway-kong.json                             24.43Ki ± 0%   24.43Ki ± 0%       ~ (p=0.897 n=10)
api-gateway-non-proxy-async.json                  48.15Ki ± 0%   48.09Ki ± 0%  -0.12% (p=0.000 n=10)
api-gateway-non-proxy.json                        47.36Ki ± 0%   47.29Ki ± 0%  -0.14% (p=0.000 n=10)
api-gateway-websocket-connect.json                25.54Ki ± 0%   25.51Ki ± 0%  -0.13% (p=0.000 n=10)
api-gateway-websocket-default.json                21.44Ki ± 0%   21.41Ki ± 0%  -0.14% (p=0.000 n=10)
api-gateway-websocket-disconnect.json             21.22Ki ± 0%   21.19Ki ± 0%  -0.18% (p=0.000 n=10)
api-gateway.json                                  49.60Ki ± 0%   49.59Ki ± 0%       ~ (p=0.424 n=10)
application-load-balancer.json                    23.32Ki ± 0%   22.38Ki ± 0%  -4.03% (p=0.000 n=10)
cloudfront.json                                   17.68Ki ± 0%   17.66Ki ± 0%  -0.11% (p=0.010 n=10)
cloudwatch-events.json                            11.74Ki ± 0%   11.70Ki ± 0%  -0.32% (p=0.000 n=10)
cloudwatch-logs.json                              53.38Ki ± 0%   53.38Ki ± 0%       ~ (p=0.591 n=10)
custom.json                                       9.748Ki ± 0%   9.732Ki ± 0%  -0.17% (p=0.050 n=10)
dynamodb.json                                     40.81Ki ± 0%   40.79Ki ± 0%       ~ (p=0.217 n=10)
empty.json                                        9.312Ki ± 0%   9.281Ki ± 0%  -0.34% (p=0.043 n=10)
eventbridge-custom.json                           15.01Ki ± 0%   15.03Ki ± 0%       ~ (p=0.148 n=10)
eventbridge-no-bus.json                           13.98Ki ± 0%   13.98Ki ± 0%       ~ (p=0.670 n=10)
eventbridge-no-timestamp.json                     13.98Ki ± 0%   14.00Ki ± 0%       ~ (p=0.255 n=10)
eventbridgesns.json                               20.98Ki ± 0%   20.95Ki ± 0%  -0.14% (p=0.012 n=10)
eventbridgesqs.json                               25.20Ki ± 0%   25.18Ki ± 0%       ~ (p=0.271 n=10)
http-api.json                                     23.94Ki ± 0%   23.87Ki ± 0%  -0.29% (p=0.029 n=10)
kinesis-batch.json                                27.17Ki ± 0%   27.11Ki ± 0%  -0.24% (p=0.015 n=10)
kinesis.json                                      17.90Ki ± 1%   17.88Ki ± 1%       ~ (p=0.448 n=10)
s3.json                                           20.50Ki ± 0%   20.39Ki ± 1%  -0.55% (p=0.043 n=10)
sns-batch.json                                    39.95Ki ± 0%   40.00Ki ± 0%       ~ (p=0.305 n=10)
sns.json                                          25.20Ki ± 1%   25.22Ki ± 0%       ~ (p=0.516 n=10)
snssqs.json                                       53.91Ki ± 0%   53.87Ki ± 0%       ~ (p=0.796 n=10)
snssqs_no_dd_context.json                         47.64Ki ± 0%   47.47Ki ± 0%  -0.35% (p=0.045 n=10)
sqs-aws-header.json                               19.49Ki ± 0%   19.45Ki ± 1%       ~ (p=0.280 n=10)
sqs-batch.json                                    42.35Ki ± 0%   42.34Ki ± 0%       ~ (p=0.971 n=10)
sqs.json                                          26.16Ki ± 1%   26.16Ki ± 1%       ~ (p=0.971 n=10)
sqs_no_dd_context.json                            21.91Ki ± 1%   21.91Ki ± 1%       ~ (p=0.986 n=10)
stepfunction.json                                 14.36Ki ± 1%   14.32Ki ± 1%       ~ (p=0.382 n=10)
geomean                                           24.62Ki        24.56Ki       -0.23%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             629.5 ± 0%   630.0 ± 0%       ~ (p=0.650 n=10)
api-gateway-kong-appsec.json                        488.0 ± 0%   488.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-kong.json                               466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    726.0 ± 0%   726.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-non-proxy.json                          716.0 ± 0%   716.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-connect.json                  453.0 ± 0%   453.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-default.json                  379.0 ± 0%   379.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-disconnect.json               370.0 ± 0%   370.0 ± 0%       ~ (p=0.211 n=10)
api-gateway.json                                    791.0 ± 0%   790.5 ± 0%       ~ (p=0.650 n=10)
application-load-balancer.json                      353.0 ± 0%   352.0 ± 0%  -0.28% (p=0.000 n=10)
cloudfront.json                                     284.0 ± 0%   284.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudwatch-events.json                              220.0 ± 0%   220.0 ± 0%       ~ (p=1.000 n=10)
cloudwatch-logs.json                                215.0 ± 0%   215.5 ± 0%       ~ (p=1.000 n=10)
custom.json                                         168.0 ± 1%   168.0 ± 1%       ~ (p=1.000 n=10)
dynamodb.json                                       589.0 ± 0%   589.0 ± 0%       ~ (p=0.690 n=10)
empty.json                                          160.0 ± 1%   159.0 ± 1%       ~ (p=0.656 n=10)
eventbridge-custom.json                             266.0 ± 0%   266.5 ± 0%       ~ (p=0.141 n=10)
eventbridge-no-bus.json                             257.0 ± 0%   257.0 ± 0%       ~ (p=0.303 n=10)
eventbridge-no-timestamp.json                       257.0 ± 0%   257.5 ± 0%       ~ (p=0.470 n=10)
eventbridgesns.json                                 326.0 ± 0%   326.0 ± 0%       ~ (p=0.690 n=10)
eventbridgesqs.json                                 367.5 ± 0%   367.5 ± 0%       ~ (p=1.000 n=10)
http-api.json                                       434.0 ± 0%   434.5 ± 0%       ~ (p=0.873 n=10)
kinesis-batch.json                                  392.5 ± 0%   392.0 ± 1%       ~ (p=0.270 n=10)
kinesis.json                                        286.0 ± 1%   286.0 ± 1%       ~ (p=0.660 n=10)
s3.json                                             359.5 ± 0%   358.5 ± 0%       ~ (p=0.281 n=10)
sns-batch.json                                      479.0 ± 0%   479.5 ± 0%       ~ (p=0.492 n=10)
sns.json                                            347.0 ± 1%   347.5 ± 0%       ~ (p=0.602 n=10)
snssqs.json                                         478.5 ± 0%   479.0 ± 0%       ~ (p=0.155 n=10)
snssqs_no_dd_context.json                           437.0 ± 0%   435.5 ± 0%       ~ (p=0.218 n=10)
sqs-aws-header.json                                 287.0 ± 0%   286.5 ± 1%       ~ (p=0.242 n=10)
sqs-batch.json                                      517.0 ± 1%   517.0 ± 1%       ~ (p=0.939 n=10)
sqs.json                                            363.0 ± 1%   363.0 ± 1%       ~ (p=0.894 n=10)
sqs_no_dd_context.json                              349.5 ± 1%   350.5 ± 1%       ~ (p=0.424 n=10)
stepfunction.json                                   238.5 ± 1%   238.5 ± 1%       ~ (p=0.931 n=10)
geomean                                             367.2        367.2       -0.01%
¹ all samples are equal

agent-platform-auto-pr · 2024-11-04T22:12:58Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48206516 --os-family=ubuntu

Note: This applies to commit f5f0af6

cit-pr-commenter · 2024-11-04T22:19:30Z

Regression Detector

purple4reina · 2024-11-05T18:57:13Z

/merge

dd-devflow · 2024-11-05T18:57:22Z

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

agent-platform-auto-pr · 2024-11-13T15:00:12Z

The backport to 7.60.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.60.x 7.60.x
# Navigate to the new working tree
cd .worktrees/backport-7.60.x
# Create a new branch
git switch --create backport-30743-to-7.60.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4314c5ffd7836b12f2ee264430d9aeaad25977eb
# Push it to GitHub
git push --set-upstream origin backport-30743-to-7.60.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.60.x

Then, create a pull request where the base branch is 7.60.x and the compare/head branch is backport-30743-to-7.60.x.

Change StartServerlessTraceAgent to use args struct.

e39c815

github-actions bot added the medium review PR review might take time label Nov 4, 2024

Add AzureContainerAppTags to trace agent config struct.

43e6f8b

purple4reina force-pushed the rey.abolofia/global-tags-safe branch from 7284fe0 to 43e6f8b Compare November 4, 2024 21:20

purple4reina added team/serverless qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Nov 4, 2024

purple4reina added this to the Triage milestone Nov 4, 2024

purple4reina marked this pull request as ready for review November 4, 2024 21:29

purple4reina requested review from a team as code owners November 4, 2024 21:29

duncanpharvey approved these changes Nov 4, 2024

View reviewed changes

ajgajg1134 approved these changes Nov 4, 2024

View reviewed changes

purple4reina force-pushed the rey.abolofia/global-tags-safe branch from cf70204 to 6a4bfe9 Compare November 4, 2024 21:44

purple4reina added 2 commits November 4, 2024 13:45

Fix linting issue.

544a1c6

Use AzureContainerAppTags for azure tags.

f5f0af6

purple4reina force-pushed the rey.abolofia/global-tags-safe branch from 6a4bfe9 to f5f0af6 Compare November 4, 2024 21:45

duncanista approved these changes Nov 5, 2024

View reviewed changes

dd-mergequeue bot merged commit 4314c5f into main Nov 5, 2024
227 of 228 checks passed

dd-mergequeue bot deleted the rey.abolofia/global-tags-safe branch November 5, 2024 19:38

github-actions bot modified the milestones: Triage, 7.61.0 Nov 5, 2024

duncanpharvey mentioned this pull request Nov 6, 2024

Add Back Tags to Spans Sent from Serverless-Init #30813

Merged

duncanpharvey added the backport/7.60.x Automatically create a backport PR to 7.60.x label Nov 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix race condition setting global tags in Azure Container Apps. #30743

Fix race condition setting global tags in Azure Container Apps. #30743

purple4reina commented Nov 4, 2024 •

edited

Loading

duncanpharvey left a comment

ajgajg1134 left a comment

github-actions bot commented Nov 4, 2024

agent-platform-auto-pr bot commented Nov 4, 2024

cit-pr-commenter bot commented Nov 4, 2024

purple4reina commented Nov 5, 2024

dd-devflow bot commented Nov 5, 2024

agent-platform-auto-pr bot commented Nov 13, 2024

Fix race condition setting global tags in Azure Container Apps. #30743

Fix race condition setting global tags in Azure Container Apps. #30743

Conversation

purple4reina commented Nov 4, 2024 • edited Loading

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

duncanpharvey left a comment

Choose a reason for hiding this comment

ajgajg1134 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 4, 2024

Serverless Benchmark Results

agent-platform-auto-pr bot commented Nov 4, 2024

Test changes on VM

cit-pr-commenter bot commented Nov 4, 2024

Regression Detector

purple4reina commented Nov 5, 2024

dd-devflow bot commented Nov 5, 2024

agent-platform-auto-pr bot commented Nov 13, 2024

purple4reina commented Nov 4, 2024 •

edited

Loading