Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smp]: prevent some empty regression detector comments #30777

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[smp]: prevent some empty regression detector comments #30777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .gitlab/functional_test/regression_detector.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ single-machine-performance-regression_detector:
script:
# Ensure output files exist for artifact downloads step
- mkdir outputs # Also needed for smp job sync step
- touch outputs/report.md # Will be emitted by smp job sync
# Compute merge base of current commit and `main`
- git fetch origin
- SMP_BASE_BRANCH=$(inv release.get-release-json-value base_branch)
Expand Down Expand Up @@ -158,6 +157,14 @@ single-machine-performance-regression_detector-pr-comment:
FF_KUBERNETES_HONOR_ENTRYPOINT: false
allow_failure: true # allow_failure here should have same setting as in job above
script: # ignore error message about no PR, because it happens for dev branches without PRs
# Prevent posting empty Regression Detector report if Markdown report is not found or
# has zero size.
- |
if [[ ! -s "outputs/report.md" ]]
then
echo "ERROR: Regression Detector report not found -- no PR comment posted"
exit 1
fi
# We need to transform the Markdown report into a valid JSON string (without
# quotes) in order to pass a well-formed payload to the PR commenting
# service. Note that on macOS, the "-z" flag is invalid for `sed` (but
Expand Down
Loading