Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable otel_to_otel_logs #30781

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

blt
Copy link
Contributor

@blt blt commented Nov 5, 2024

We've noticed an increase in timeouts for this experiment. While SMP
investigates, disable the experiment generally allowing other Regression
Detector runs to complete in a reasonable time.

REF SMPTNG-520

Copy link
Contributor Author

blt commented Nov 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blt and the rest of your teammates on Graphite Graphite

@blt blt added the qa/no-code-change No code change in Agent code requiring validation label Nov 5, 2024 — with Graphite App
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 5, 2024
@blt blt marked this pull request as ready for review November 5, 2024 18:11
@blt blt requested a review from a team as a code owner November 5, 2024 18:11
@blt
Copy link
Contributor Author

blt commented Nov 5, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 5, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 5, 2024

[Fast Unit Tests Report]

On pipeline 48309049 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@dd-devflow
Copy link

dd-devflow bot commented Nov 5, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

Copy link
Contributor Author

blt commented Nov 5, 2024

Merge activity

  • Nov 5, 2:10 PM EST: Graphite couldn't merge this PR because it failed for an unknown reason.

Copy link

cit-pr-commenter bot commented Nov 5, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 20e0f304-571c-4c72-8812-d3e4b99ed282

Baseline: 4314c5f
Comparison: 019f632
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +1.17 [+1.04, +1.31] 1 Logs
basic_py_check % cpu utilization +1.01 [-2.84, +4.85] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.19 [-0.07, +0.44] 1 Logs
quality_gate_idle memory utilization +0.18 [+0.12, +0.23] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.48, +0.51] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.33, +0.34] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.09, +0.09] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.23, +0.22] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.18, +0.17] 1 Logs
idle memory utilization -0.01 [-0.06, +0.04] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.04 [-0.14, +0.06] 1 Logs bounds checks dashboard
idle_all_features memory utilization -0.46 [-0.56, -0.35] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.89 [-0.94, -0.84] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.09 [-1.82, -0.37] 1 Logs
pycheck_lots_of_tags % cpu utilization -1.28 [-4.83, +2.26] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_300ms_latency memory_usage 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10 bounds checks dashboard
idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dd-devflow
Copy link

dd-devflow bot commented Nov 5, 2024

MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 71c51b5:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

If you need support, contact us on Slack #devflow with those details!

We've noticed an increase in timeouts for this experiment. While we
investigate, disable the experiment generally allowing other Regression
Detector runs to complete in a reasonable time.

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt blt force-pushed the blt/disable_otel_to_otel_logs branch from e34e2b1 to 019f632 Compare November 5, 2024 22:12
@blt
Copy link
Contributor Author

blt commented Nov 5, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 5, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Nov 5, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit af8e4b2 into main Nov 5, 2024
199 of 201 checks passed
@dd-mergequeue dd-mergequeue bot deleted the blt/disable_otel_to_otel_logs branch November 5, 2024 23:15
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 5, 2024
scottopell added a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/single-machine-performance Single Machine Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants